Source/core/page/FrameView.cpp - Issue 23537039: paintingRoot of a renderobject should be the renderer of its enclosingLayer RenderLayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FrameView.cpp

Issue 23537039: paintingRoot of a renderobject should be the renderer of its enclosingLayer RenderLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tests added Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/FrameView.cpp

diff --git a/Source/core/page/FrameView.cpp b/Source/core/page/FrameView.cpp

index d48329928539696c80b5420417bcca36e5195660..6935eb3d8744b892b0acc9fa5a90470f49a4e500 100644

--- a/Source/core/page/FrameView.cpp

+++ b/Source/core/page/FrameView.cpp

@@ -2917,7 +2917,8 @@ void FrameView::paintContents(GraphicsContext* p, const IntRect& rect)

RenderObject::SetLayoutNeededForbiddenScope forbidSetNeedsLayout(rootLayer->renderer());

#endif

- rootLayer->paint(p, rect, m_paintBehavior, eltRenderer);

+ RenderObject* enclosingLayerRenderer = eltRenderer->enclosingLayer() ? eltRenderer->enclosingLayer()->renderer() : eltRenderer;

+ rootLayer->paint(p, rect, m_paintBehavior, enclosingLayerRenderer);

if (rootLayer->containsDirtyOverlayScrollbars())

rootLayer->paintOverlayScrollbars(p, rect, m_paintBehavior, eltRenderer);

« ManualTests/drag-inline-block.html ('K') | « ManualTests/drag-inline-block.html ('k') | no next file » | no next file with comments »