Issue 23537038: Remove override mode from BinaryOpStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23537038: Remove override mode from BinaryOpStub (Closed)

Created:
7 years, 3 months ago by oliv

Modified:
7 years, 3 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove override mode from BinaryOpStub This gives us a revertable commit and tries to prove that the override mode is bogus. BUG=

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -234 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	13 chunks	+17 lines, -43 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View	6 chunks	+1 line, -9 lines	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	11 chunks	+21 lines, -87 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+13 lines, -41 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

oliv

7 years, 3 months ago (2013-09-16 07:47:07 UTC) #2

On 2013/09/13 14:54:26, oliv wrote:

lets put this on hold, since it is kind of an open discussion now...