Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 23537037: [CSS Grid Layout] Use CSS_FR for flexible lengths instead of CSS_DIMENSION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 23537037: [CSS Grid Layout] Use CSS_FR for flexible lengths instead of CSS_DIMENSION (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed the FIXME :) Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index c893dd4ad2f61b6dfc26f1e9b8f6668e30b7dce2..1f7fc11cc9bf7821b59e7e7851b5a814242e5488 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -946,7 +946,7 @@ static bool createGridTrackBreadth(CSSPrimitiveValue* primitiveValue, const Styl

if (primitiveValue->isFlex()) {

// Fractional unit.

- workingLength.setFlex(primitiveValue->getFloatValue());

+ workingLength.setFlex(primitiveValue->getDoubleValue());

return true;

}

« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | no next file » | no next file with comments »