Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 23537037: [CSS Grid Layout] Use CSS_FR for flexible lengths instead of CSS_DIMENSION (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2012 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 case CSS_HZ: 981 case CSS_HZ:
982 text = formatNumber(m_value.num, "hz"); 982 text = formatNumber(m_value.num, "hz");
983 break; 983 break;
984 case CSS_KHZ: 984 case CSS_KHZ:
985 text = formatNumber(m_value.num, "khz"); 985 text = formatNumber(m_value.num, "khz");
986 break; 986 break;
987 case CSS_TURN: 987 case CSS_TURN:
988 text = formatNumber(m_value.num, "turn"); 988 text = formatNumber(m_value.num, "turn");
989 break; 989 break;
990 case CSS_DIMENSION: 990 case CSS_DIMENSION:
991 text = m_value.string; 991 // FIXME
Julien - ping for review 2013/09/13 16:44:51 I don't like this change, even if you are revertin
992 break; 992 break;
993 case CSS_STRING: 993 case CSS_STRING:
994 text = formattingFlag == AlwaysQuoteCSSString ? quoteCSSString(m_val ue.string) : quoteCSSStringIfNeeded(m_value.string); 994 text = formattingFlag == AlwaysQuoteCSSString ? quoteCSSString(m_val ue.string) : quoteCSSStringIfNeeded(m_value.string);
995 break; 995 break;
996 case CSS_URI: 996 case CSS_URI:
997 text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ")"; 997 text = "url(" + quoteCSSURLIfNeeded(m_value.string) + ")";
998 break; 998 break;
999 case CSS_VALUE_ID: 999 case CSS_VALUE_ID:
1000 text = valueName(m_value.valueID); 1000 text = valueName(m_value.valueID);
1001 break; 1001 break;
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 return m_value.parserOperator == other.m_value.parserOperator; 1332 return m_value.parserOperator == other.m_value.parserOperator;
1333 case CSS_CALC: 1333 case CSS_CALC:
1334 return m_value.calc && other.m_value.calc && m_value.calc->equals(*other .m_value.calc); 1334 return m_value.calc && other.m_value.calc && m_value.calc->equals(*other .m_value.calc);
1335 case CSS_SHAPE: 1335 case CSS_SHAPE:
1336 return m_value.shape && other.m_value.shape && m_value.shape->equals(*ot her.m_value.shape); 1336 return m_value.shape && other.m_value.shape && m_value.shape->equals(*ot her.m_value.shape);
1337 } 1337 }
1338 return false; 1338 return false;
1339 } 1339 }
1340 1340
1341 } // namespace WebCore 1341 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698