chrome/browser/ui/content_settings/content_setting_bubble_model.h - Issue 23537029: Save password functionality added to the save password bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review 1 Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc ('K') | « chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | chrome/browser/ui/views/content_setting_bubble_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

index 73f350035191d928f49dede208b288b5a6b5561d..71f35bd9b5ddcf4d1a2475325b35f23f5a2d4c15 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

@@ -196,11 +196,10 @@ class SavePasswordBubbleModel : public ContentSettingTitleAndLinkModel {

SavePasswordBubbleModel(Delegate* delegate,

content::WebContents* web_contents,

Profile* profile);

- virtual ~SavePasswordBubbleModel() {}

+ virtual ~SavePasswordBubbleModel();

virtual void OnCancelClicked() OVERRIDE;

virtual void OnSaveClicked() OVERRIDE;

private:

Peter Kasting 2013/09/10 23:04:41 Nit: Blank line above this.

npentrel 2013/09/11 09:10:42 Done.

- // Sets the title of the bubble.

void SetTitle();

TabSpecificContentSettings::PasswordSavingState state_;