Save password functionality added to the save password bubble

chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
 
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 13 matching lines @@
 ~BrowserContentSettingBubbleModelDelegate() {
 }
 
 void BrowserContentSettingBubbleModelDelegate::ShowCollectedCookiesDialog(
     content::WebContents* web_contents) {
   chrome::ShowCollectedCookiesDialog(web_contents);
 }
 
 void BrowserContentSettingBubbleModelDelegate::ShowContentSettingsPage(
     ContentSettingsType type) {
-  if (type == CONTENT_SETTINGS_TYPE_MIXEDSCRIPT) {
-    // We don't (yet?) implement user-settable exceptions for mixed script
-    // blocking, so bounce to an explanatory page for now.
-    GURL url(google_util::AppendGoogleLocaleParam(
-        GURL(kInsecureScriptHelpUrl)));
-    chrome::AddSelectedTabWithURL(browser_, url, content::PAGE_TRANSITION_LINK);
-    return;
+  switch (type) {
+    case CONTENT_SETTINGS_TYPE_MIXEDSCRIPT: {
+      // We don't (yet?) implement user-settable exceptions for mixed script
+      // blocking, so bounce to an explanatory page for now.
+      GURL url(google_util::AppendGoogleLocaleParam(
+          GURL(kInsecureScriptHelpUrl)));

[Peter Kasting, 2013/09/10 23:04:41]

Nit: I suggest inlining this into the next statement in order to avoid the need
to put braces around this case.

[npentrel, 2013/09/11 09:10:42]

Done.

+      chrome::AddSelectedTabWithURL(browser_, url,
+                                    content::PAGE_TRANSITION_LINK);
+      break;

[Peter Kasting, 2013/09/10 23:04:41]

Nit: Use return instead of break where possible.

[npentrel, 2013/09/11 09:10:42]

Done.

+    }
+    case CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS:
+      chrome::ShowSettingsSubPage(browser_, chrome::kHandlerSettingsSubPage);
+      break;
+    case CONTENT_SETTINGS_TYPE_SAVE_PASSWORD:
+      chrome::ShowSettingsSubPage(browser_, chrome::kPasswordManagerSubPage);
+      break;
+    default:
+      chrome::ShowContentSettings(browser_, type);
+      break;
   }
-
-  if (type == CONTENT_SETTINGS_TYPE_PROTOCOL_HANDLERS) {
-    chrome::ShowSettingsSubPage(browser_, chrome::kHandlerSettingsSubPage);
-    return;
-  }
-
-  if (type == CONTENT_SETTINGS_TYPE_SAVE_PASSWORD) {
-    chrome::ShowSettingsSubPage(browser_, chrome::kPasswordManagerSubPage);
-    return;
-  }
-
-  chrome::ShowContentSettings(browser_, type);
 }