Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tests/standalone/io/file_system_watcher_test.dart

Issue 23537021: Relax expectations for events on mac, and allow move events to not have a destination. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/file_system_watcher_test.dart
diff --git a/tests/standalone/io/file_system_watcher_test.dart b/tests/standalone/io/file_system_watcher_test.dart
index d94b70ccee1edeff8aaac54ab205270b28d99042..fef2d6ea333067868623bf5abb40214697cd8471 100644
--- a/tests/standalone/io/file_system_watcher_test.dart
+++ b/tests/standalone/io/file_system_watcher_test.dart
@@ -70,7 +70,9 @@ void testWatchMoveFile() {
sub = watcher.listen((event) {
if (event is FileSystemMoveEvent) {
Expect.isTrue(event.path.endsWith('file'));
- Expect.isTrue(event.destination.endsWith('file2'));
+ if (event.destination != null) {
+ Expect.isTrue(event.destination.endsWith('file2'));
+ }
sub.cancel();
asyncEnd();
dir.deleteSync(recursive: true);
@@ -167,7 +169,9 @@ void testMultipleEvents() {
dir.deleteSync();
break;
}
- if (newState < state) throw "Bad state";
+ if (!Platform.isMacOS) {
+ if (newState < state) throw "Bad state";
+ }
state = newState;
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698