| Index: components/autofill/core/browser/autofill_metrics.h
|
| diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
|
| index 418a716f22da5a715c2d0e865f0fe599ea6db754..41b6077816c824c3ac68c66441c4ec8e513429d4 100644
|
| --- a/components/autofill/core/browser/autofill_metrics.h
|
| +++ b/components/autofill/core/browser/autofill_metrics.h
|
| @@ -347,56 +347,46 @@ class AutofillMetrics {
|
|
|
| virtual void LogUserHappinessMetric(UserHappinessMetric metric) const;
|
|
|
| - // Logs |state| to the dismissal states histogram for |dialog_type|.
|
| - virtual void LogDialogDismissalState(autofill::DialogType dialog_type,
|
| - DialogDismissalState state) const;
|
| + // Logs |state| to the dismissal states histogram.
|
| + virtual void LogDialogDismissalState(DialogDismissalState state) const;
|
|
|
| // This should be called as soon as the user's signed-in status and Wallet
|
| // item count is known. Records that a user starting out in |user_state| is
|
| - // interacting with a dialog of |dialog_type|.
|
| + // interacting with a dialog.
|
| virtual void LogDialogInitialUserState(
|
| - autofill::DialogType dialog_type,
|
| DialogInitialUserStateMetric user_type) const;
|
|
|
| - // Logs the time elapsed between the dialog being shown for |dialog_type| and
|
| - // when it is ready for user interaction.
|
| - virtual void LogDialogLatencyToShow(autofill::DialogType dialog_type,
|
| - const base::TimeDelta& duration) const;
|
| + // Logs the time elapsed between the dialog being shown and when it is ready
|
| + // for user interaction.
|
| + virtual void LogDialogLatencyToShow(const base::TimeDelta& duration) const;
|
|
|
| - // Logs |event| to the popup events histogram for |dialog_type|.
|
| - virtual void LogDialogPopupEvent(autofill::DialogType dialog_type,
|
| - DialogPopupEvent event) const;
|
| + // Logs |event| to the popup events histogram.
|
| + virtual void LogDialogPopupEvent(DialogPopupEvent event) const;
|
|
|
| - // Logs |metric| to the security metrics histogram for |dialog_type|.
|
| - virtual void LogDialogSecurityMetric(autofill::DialogType dialog_type,
|
| - DialogSecurityMetric metric) const;
|
| + // Logs |metric| to the security metrics histogram.
|
| + virtual void LogDialogSecurityMetric(DialogSecurityMetric metric) const;
|
|
|
| - // This should be called when the Autofill dialog, invoked by a dialog of type
|
| - // |dialog_type|, is closed. |duration| should be the time elapsed between
|
| - // the dialog being shown and it being closed. |dismissal_action| should
|
| - // indicate whether the user dismissed the dialog by submitting the form data
|
| - // or by canceling.
|
| + // This should be called when the Autofill dialog is closed. |duration|
|
| + // should be the time elapsed between the dialog being shown and it being
|
| + // closed. |dismissal_action| should indicate whether the user dismissed
|
| + // the dialog by submitting the form data or by canceling.
|
| virtual void LogDialogUiDuration(
|
| const base::TimeDelta& duration,
|
| - autofill::DialogType dialog_type,
|
| DialogDismissalAction dismissal_action) const;
|
|
|
| - // Logs |event| to the UI events histogram for |dialog_type|.
|
| - virtual void LogDialogUiEvent(autofill::DialogType dialog_type,
|
| - DialogUiEvent event) const;
|
| + // Logs |event| to the UI events histogram.
|
| + virtual void LogDialogUiEvent(DialogUiEvent event) const;
|
|
|
| - // Logs |metric| to the Wallet errors histogram for |dialog_type|.
|
| - virtual void LogWalletErrorMetric(autofill::DialogType dialog_type,
|
| - WalletErrorMetric metric) const;
|
| + // Logs |metric| to the Wallet errors histogram.
|
| + virtual void LogWalletErrorMetric(WalletErrorMetric metric) const;
|
|
|
| // Logs the network request time of Wallet API calls.
|
| virtual void LogWalletApiCallDuration(
|
| WalletApiCallMetric metric,
|
| const base::TimeDelta& duration) const;
|
|
|
| - // Logs |required_action| to the required actions histogram for |dialog_type|.
|
| + // Logs |required_action| to the required actions histogram.
|
| virtual void LogWalletRequiredActionMetric(
|
| - autofill::DialogType dialog_type,
|
| WalletRequiredActionMetric required_action) const;
|
|
|
| // This should be called when a form that has been Autofilled is submitted.
|
|
|