Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3452)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 07547bb096eeab28265ee048406413c3a0245c34..5525d64adea01ef16c2a18e21b2e6bb0b73c8b2e 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -89,7 +89,6 @@ void TabAutofillManagerDelegate::ConfirmSaveCreditCard(
void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
- DialogType dialog_type,
const base::Callback<void(const FormStructure*,
const std::string&)>& callback) {
HideRequestAutocompleteDialog();
@@ -97,7 +96,6 @@ void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
dialog_controller_ = AutofillDialogController::Create(web_contents_,
form,
source_url,
- dialog_type,
callback);
if (dialog_controller_) {
dialog_controller_->Show();
@@ -167,13 +165,7 @@ void TabAutofillManagerDelegate::DidNavigateMainFrame(
if (!dialog_controller_.get())
return;
- bool was_redirect = details.entry &&
- content::PageTransitionIsRedirect(details.entry->GetTransitionType());
Ilya Sherman 2013/09/03 20:57:05 nit: Are there any #included headers that are no l
Raman Kakilate 2013/09/03 21:50:31 Done.
-
- if (dialog_controller_->GetDialogType() == DIALOG_TYPE_REQUEST_AUTOCOMPLETE ||
- !was_redirect) {
- HideRequestAutocompleteDialog();
- }
+ HideRequestAutocompleteDialog();
}
void TabAutofillManagerDelegate::WebContentsDestroyed(

Powered by Google App Engine
This is Rietveld 408576698