rAc: Get rid of dialog type in rAc, there is only one type left now.

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_type.h"
@@ skipping 140 matching lines @@
     default:
       NOTREACHED();
       group = AMBIGUOUS;
   }
 
   // Interpolate the |metric| with the |group|, so that all metrics for a given
   // |group| are adjacent.
   return (group * num_possible_metrics) + metric;
 }
 
-// Returns the histogram prefix to use for reporting metrics for |dialog_type|.
-std::string GetPrefixForDialogType(autofill::DialogType dialog_type) {
-  switch (dialog_type) {
-    case autofill::DIALOG_TYPE_AUTOCHECKOUT:
-      return "Autocheckout";
-
-    case autofill::DIALOG_TYPE_REQUEST_AUTOCOMPLETE:
-      return "RequestAutocomplete";
-  }
-
-  NOTREACHED();
-  return "UnknownDialogType";
-}
-
 std::string WalletApiMetricToString(
     AutofillMetrics::WalletApiCallMetric metric) {
   switch (metric) {
     case AutofillMetrics::ACCEPT_LEGAL_DOCUMENTS:
       return "AcceptLegalDocuments";
     case AutofillMetrics::AUTHENTICATE_INSTRUMENT:
       return "AuthenticateInstrument";
     case AutofillMetrics::GET_FULL_WALLET:
       return "GetFullWallet";
     case AutofillMetrics::GET_WALLET_ITEMS:
@@ skipping 139 matching lines @@
 }
 
 void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) const {
   DCHECK_LT(metric, NUM_INFO_BAR_METRICS);
 
   UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardInfoBar", metric,
                             NUM_INFO_BAR_METRICS);
 }
 
 void AutofillMetrics::LogDialogDismissalState(
-    autofill::DialogType dialog_type,
     DialogDismissalState state) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".DismissalState";
+  std::string name = "RequestAutocomplete.DismissalState";
   LogUMAHistogramEnumeration(name, state, NUM_DIALOG_DISMISSAL_STATES);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
 void AutofillMetrics::LogDialogInitialUserState(
-    autofill::DialogType dialog_type,
     DialogInitialUserStateMetric user_type) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".InitialUserState";
+  std::string name = "RequestAutocomplete.InitialUserState";
   LogUMAHistogramEnumeration(
       name, user_type, NUM_DIALOG_INITIAL_USER_STATE_METRICS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
 void AutofillMetrics::LogDialogLatencyToShow(
-    autofill::DialogType dialog_type,
     const base::TimeDelta& duration) const {
-  std::string name =
-      GetPrefixForDialogType(dialog_type) + ".UiLatencyToShow";
+  std::string name = "RequestAutocomplete.UiLatencyToShow";
   LogUMAHistogramTimes(name, duration);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_TIMES macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
-void AutofillMetrics::LogDialogPopupEvent(autofill::DialogType dialog_type,
-                                          DialogPopupEvent event) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".PopupInDialog";
+void AutofillMetrics::LogDialogPopupEvent(DialogPopupEvent event) const {
+  std::string name = "RequestAutocomplete.PopupInDialog";
   LogUMAHistogramEnumeration(name, event, NUM_DIALOG_POPUP_EVENTS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
 void AutofillMetrics::LogDialogSecurityMetric(
-    autofill::DialogType dialog_type,
     DialogSecurityMetric metric) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".Security";
+  std::string name = "RequestAutocomplete.Security";
   LogUMAHistogramEnumeration(name, metric, NUM_DIALOG_SECURITY_METRICS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
 void AutofillMetrics::LogDialogUiDuration(
     const base::TimeDelta& duration,
-    autofill::DialogType dialog_type,
     DialogDismissalAction dismissal_action) const {
-  std::string prefix = GetPrefixForDialogType(dialog_type);
-
   std::string suffix;
   switch (dismissal_action) {
     case DIALOG_ACCEPTED:
       suffix = "Submit";
       break;
 
     case DIALOG_CANCELED:
       suffix = "Cancel";
       break;
   }
 
-  LogUMAHistogramLongTimes(prefix + ".UiDuration", duration);
-  LogUMAHistogramLongTimes(prefix + ".UiDuration." + suffix, duration);
+  LogUMAHistogramLongTimes("RequestAutocomplete.UiDuration", duration);
+  LogUMAHistogramLongTimes("RequestAutocomplete.UiDuration." + suffix,
+                           duration);
 }
 
-void AutofillMetrics::LogDialogUiEvent(autofill::DialogType dialog_type,
-                                       DialogUiEvent event) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".UiEvents";
+void AutofillMetrics::LogDialogUiEvent(DialogUiEvent event) const {
+  std::string name = "RequestAutocomplete.UiEvents";
   LogUMAHistogramEnumeration(name, event, NUM_DIALOG_UI_EVENTS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:31]

Done.

 }
 
-void AutofillMetrics::LogWalletErrorMetric(autofill::DialogType dialog_type,
-                                           WalletErrorMetric metric) const {
-  std::string name = GetPrefixForDialogType(dialog_type) + ".WalletErrors";
+void AutofillMetrics::LogWalletErrorMetric(WalletErrorMetric metric) const {
+  std::string name = "RequestAutocomplete.WalletErrors";
   LogUMAHistogramEnumeration(name, metric, NUM_WALLET_ERROR_METRICS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:32]

Done.

 }
 
 void AutofillMetrics::LogWalletApiCallDuration(
     WalletApiCallMetric metric,
     const base::TimeDelta& duration) const {
   LogUMAHistogramTimes("Wallet.ApiCallDuration." +
                        WalletApiMetricToString(metric), duration);
 }
 
 void AutofillMetrics::LogWalletRequiredActionMetric(
-      autofill::DialogType dialog_type,
       WalletRequiredActionMetric required_action) const {
-  std::string name =
-      GetPrefixForDialogType(dialog_type) + ".WalletRequiredActions";
+  std::string name = "RequestAutocomplete.WalletRequiredActions";
   LogUMAHistogramEnumeration(
       name, required_action, NUM_WALLET_REQUIRED_ACTIONS);

[Ilya Sherman, 2013/09/03 20:57:05]

nit: Please update this to use the regular UMA_HISTOGRAM_ENUMERATION macro.

[Raman Kakilate, 2013/09/03 21:50:32]

Done.

 }
 
 void AutofillMetrics::LogDeveloperEngagementMetric(
     DeveloperEngagementMetric metric) const {
   DCHECK_LT(metric, NUM_DEVELOPER_ENGAGEMENT_METRICS);
 
   UMA_HISTOGRAM_ENUMERATION("Autofill.DeveloperEngagement", metric,
                             NUM_DEVELOPER_ENGAGEMENT_METRICS);
 }
 
@@ skipping 107 matching lines @@
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Query", experiment_id);
 }
 
 void AutofillMetrics::LogServerExperimentIdForUpload(
     const std::string& experiment_id) const {
   LogServerExperimentId("Autofill.ServerExperimentId.Upload", experiment_id);
 }
 
 }  // namespace autofill