Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2353693002: Remove incremental analysis cache. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove incremental analysis cache. It could cache more than what we cache currently with pub summaries. But pub and internal summaries seem to be a good level of granularity. This also makes one user less for element based summarizer. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1310dc801a3bfee2e318772a608f0f86959ea860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1553 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 2 chunks +0 lines, -504 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D pkg/analyzer/lib/src/summary/incremental_cache.dart View 1 chunk +0 lines, -656 lines 0 comments Download
D pkg/analyzer/test/src/summary/incremental_cache_test.dart View 1 chunk +0 lines, -297 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-19 20:47:01 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-09-19 20:48:30 UTC) #2
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-19 21:15:12 UTC) #3
scheglov
4 years, 3 months ago (2016-09-19 21:17:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1310dc801a3bfee2e318772a608f0f86959ea860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698