Add base::UnguessableToken << operator

Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.

Committed: https://crrev.com/13be8a310b844140227c0c9f1f54991478bef8d2
Cr-Commit-Position: refs/heads/master@{#419647}

[tguilbert, 2016-09-19 23:02:18]

Description was changed from

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX)

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.
==========

to

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.
==========

[tguilbert, 2016-09-19 23:10:39]

tguilbert@chromium.org changed reviewers:
+ danakj@chromium.org

[tguilbert, 2016-09-19 23:10:39]

PTAL! (I promise this should simpler than the previous UnguessableToken reviews
:P)

Thanks,
Thomas

[danakj, 2016-09-19 23:41:06]

https://codereview.chromium.org/2353663003/diff/1/base/unguessable_token.h
File base/unguessable_token.h (right):

https://codereview.chromium.org/2353663003/diff/1/base/unguessable_token.h#ne...
base/unguessable_token.h:100: return out << token.ToString();
Can you put the defn in the .cc file?

[tguilbert, 2016-09-20 00:04:53]

https://codereview.chromium.org/2353663003/diff/1/base/unguessable_token.h
File base/unguessable_token.h (right):

https://codereview.chromium.org/2353663003/diff/1/base/unguessable_token.h#ne...
base/unguessable_token.h:100: return out << token.ToString();
On 2016/09/19 23:41:05, danakj wrote:
> Can you put the defn in the .cc file?

Done.

[danakj, 2016-09-20 00:07:08]

LGTM

https://codereview.chromium.org/2353663003/diff/20001/base/unguessable_token.h
File base/unguessable_token.h (right):

https://codereview.chromium.org/2353663003/diff/20001/base/unguessable_token....
base/unguessable_token.h:98: BASE_EXPORT std::ostream& operator<<(std::ostream&
out,
nit: order this beside (after) the class, before the hash struct

[tguilbert, 2016-09-20 00:50:34]

Thank you!

https://codereview.chromium.org/2353663003/diff/20001/base/unguessable_token.h
File base/unguessable_token.h (right):

https://codereview.chromium.org/2353663003/diff/20001/base/unguessable_token....
base/unguessable_token.h:98: BASE_EXPORT std::ostream& operator<<(std::ostream&
out,
On 2016/09/20 00:07:08, danakj wrote:
> nit: order this beside (after) the class, before the hash struct

Done.

[tguilbert, 2016-09-20 00:50:40]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-09-20 00:50:41]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2353663003/#ps40001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2016-09-20 00:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:05:08]

Description was changed from

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.
==========

to

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.
==========

[commit-bot: I haz the power, 2016-09-20 02:05:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 02:06:50]

Description was changed from

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.
==========

to

==========
Add base::UnguessableToken << operator

base::UnguessableToken seems to fit the Google C++ style guide's
criterion on overloading << as a streaming operator. Notably:
-- It represents a value.
-- There is an easy human-readable string reprensetation of the value
(0 padded HEX).

This change adds an overload to the << operator, as syntactic sugar.

BUG=648441
TEST= Modified a UT to test the operator.

Committed: https://crrev.com/13be8a310b844140227c0c9f1f54991478bef8d2
Cr-Commit-Position: refs/heads/master@{#419647}
==========

[commit-bot: I haz the power, 2016-09-20 02:06:52]

Patchset 3 (id:??) landed as
https://crrev.com/13be8a310b844140227c0c9f1f54991478bef8d2
Cr-Commit-Position: refs/heads/master@{#419647}