Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2353653002: Activate pubsub for dart masters (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Activate pubsub for dart masters These don't use AutoSetupMaster, so the status pusher needs to be add in master.cfg BUG=642461 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f2d0b993a0a91a63a1d6ff3f552650d90b11da07

Patch Set 1 #

Patch Set 2 : Import #

Patch Set 3 : Remove logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M masters/master.client.dart.fyi/master.cfg View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M masters/master.client.dart.packages/master.cfg View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M masters/master.client.dart/master.cfg View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Ryan Tseng
4 years, 3 months ago (2016-09-19 19:57:56 UTC) #4
hinoka
+whesse ptal this is the last 3 masters to add to https://luci-milo.appspot.com/ :)
4 years, 3 months ago (2016-09-19 21:26:43 UTC) #18
William Hesse
LGTM. Thanks!
4 years, 3 months ago (2016-09-19 21:33:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353653002/40001
4 years, 3 months ago (2016-09-19 21:35:18 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:39:13 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/f2d0b993a0a91a63a1d6...

Powered by Google App Engine
This is Rietveld 408576698