Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: src/objects-inl.h

Issue 2353633002: [modules] Explicitly keep track of module requests. (Closed)
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7925 matching lines...) Expand 10 before | Expand all | Expand 10 after
7936 Object* ModuleInfoEntry::export_name() const { return get(kExportNameIndex); } 7936 Object* ModuleInfoEntry::export_name() const { return get(kExportNameIndex); }
7937 7937
7938 Object* ModuleInfoEntry::local_name() const { return get(kLocalNameIndex); } 7938 Object* ModuleInfoEntry::local_name() const { return get(kLocalNameIndex); }
7939 7939
7940 Object* ModuleInfoEntry::import_name() const { return get(kImportNameIndex); } 7940 Object* ModuleInfoEntry::import_name() const { return get(kImportNameIndex); }
7941 7941
7942 Object* ModuleInfoEntry::module_request() const { 7942 Object* ModuleInfoEntry::module_request() const {
7943 return get(kModuleRequestIndex); 7943 return get(kModuleRequestIndex);
7944 } 7944 }
7945 7945
7946 FixedArray* ModuleInfo::module_requests() const {
7947 return FixedArray::cast(get(kModuleRequestsIndex));
7948 }
7949
7946 FixedArray* ModuleInfo::special_exports() const { 7950 FixedArray* ModuleInfo::special_exports() const {
7947 return FixedArray::cast(get(kSpecialExportsIndex)); 7951 return FixedArray::cast(get(kSpecialExportsIndex));
7948 } 7952 }
7949 7953
7950 FixedArray* ModuleInfo::regular_exports() const { 7954 FixedArray* ModuleInfo::regular_exports() const {
7951 return FixedArray::cast(get(kRegularExportsIndex)); 7955 return FixedArray::cast(get(kRegularExportsIndex));
7952 } 7956 }
7953 7957
7954 #ifdef DEBUG 7958 #ifdef DEBUG
7955 bool ModuleInfo::Equals(ModuleInfo* other) const { 7959 bool ModuleInfo::Equals(ModuleInfo* other) const {
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
8286 #undef WRITE_INT64_FIELD 8290 #undef WRITE_INT64_FIELD
8287 #undef READ_BYTE_FIELD 8291 #undef READ_BYTE_FIELD
8288 #undef WRITE_BYTE_FIELD 8292 #undef WRITE_BYTE_FIELD
8289 #undef NOBARRIER_READ_BYTE_FIELD 8293 #undef NOBARRIER_READ_BYTE_FIELD
8290 #undef NOBARRIER_WRITE_BYTE_FIELD 8294 #undef NOBARRIER_WRITE_BYTE_FIELD
8291 8295
8292 } // namespace internal 8296 } // namespace internal
8293 } // namespace v8 8297 } // namespace v8
8294 8298
8295 #endif // V8_OBJECTS_INL_H_ 8299 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698