Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/assembler_arm64_test.cc

Issue 235363005: Adds comparisons, labels, branches to arm64 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/assembler_arm64.h ('K') | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/constants_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64_test.cc
===================================================================
--- runtime/vm/assembler_arm64_test.cc (revision 34984)
+++ runtime/vm/assembler_arm64_test.cc (working copy)
@@ -491,9 +491,7 @@
EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
}
-// TODO(zra): ands and bics after branches are implemented.
-
// Logical immediate operations.
ASSEMBLER_TEST_GENERATE(AndImm, assembler) {
__ movz(R1, 42, 0);
@@ -553,8 +551,333 @@
EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
}
-// TODO(zra): andis after branches are implemented.
+// Comparisons, branching.
+ASSEMBLER_TEST_GENERATE(BranchALForward, assembler) {
+ Label l;
+ __ movz(R0, 42, 0);
+ __ b(&l, AL);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(BranchALForward, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(BranchALBackwards, assembler) {
+ Label l, leave;
+ __ movz(R0, 42, 0);
+ __ b(&l, AL);
+
+ __ movz(R0, 0, 0);
+ __ Bind(&leave);
+ __ ret();
+ __ movz(R0, 0, 0);
+
+ __ Bind(&l);
+ __ b(&leave, AL);
+ __ movz(R0, 0, 0);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(BranchALBackwards, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmpEqBranch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 234, 0);
+ __ movz(R2, 234, 0);
+
+ __ cmp(R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmpEqBranch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmpEqBranchNotTaken, assembler) {
+ Label l;
+
+ __ movz(R0, 0, 0);
+ __ movz(R1, 233, 0);
+ __ movz(R2, 234, 0);
+
+ __ cmp(R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 42, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmpEqBranchNotTaken, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmpEq1Branch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 1, 0);
+
+ __ cmp(R1, Operand(1));
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmpEq1Branch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmnEq1Branch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movn(R1, 0, 0); // R1 <- -1
+
+ __ cmn(R1, Operand(1));
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmnEq1Branch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmpLtBranch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 233, 0);
+ __ movz(R2, 234, 0);
+
+ __ cmp(R1, Operand(R2));
+ __ b(&l, LT);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmpLtBranch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(CmpLtBranchNotTaken, assembler) {
+ Label l;
+
+ __ movz(R0, 0, 0);
+ __ movz(R1, 235, 0);
+ __ movz(R2, 234, 0);
+
+ __ cmp(R1, Operand(R2));
+ __ b(&l, LT);
+ __ movz(R0, 42, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(CmpLtBranchNotTaken, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AndsBranch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 2, 0);
+ __ movz(R2, 1, 0);
+
+ __ ands(R3, R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AndsBranch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AndsBranchNotTaken, assembler) {
+ Label l;
+
+ __ movz(R0, 0, 0);
+ __ movz(R1, 2, 0);
+ __ movz(R2, 2, 0);
+
+ __ ands(R3, R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 42, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AndsBranchNotTaken, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(BicsBranch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 2, 0);
+ __ movz(R2, 2, 0);
+
+ __ bics(R3, R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(BicsBranch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(BicsBranchNotTaken, assembler) {
+ Label l;
+
+ __ movz(R0, 0, 0);
+ __ movz(R1, 2, 0);
+ __ movz(R2, 1, 0);
+
+ __ bics(R3, R1, Operand(R2));
+ __ b(&l, EQ);
+ __ movz(R0, 42, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(BicsBranchNotTaken, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AndisBranch, assembler) {
+ Label l;
+
+ __ movz(R0, 42, 0);
+ __ movz(R1, 2, 0);
+
+ __ andis(R3, R1, 1);
+ __ b(&l, EQ);
+ __ movz(R0, 0, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AndisBranch, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AndisBranchNotTaken, assembler) {
+ Label l;
+
+ __ movz(R0, 0, 0);
+ __ movz(R1, 2, 0);
+
+ __ andis(R3, R1, 2);
+ __ b(&l, EQ);
+ __ movz(R0, 42, 0);
+ __ Bind(&l);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AndisBranchNotTaken, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+// Address of PC-rel offset, br, blr.
+ASSEMBLER_TEST_GENERATE(AdrBr, assembler) {
+ __ movz(R0, 123, 0);
+ __ adr(R1, 3 * Instr::kInstrSize); // R1 <- PC + 3*Instr::kInstrSize
+ __ br(R1);
+ __ ret();
+
+ // br goes here.
+ __ movz(R0, 42, 0);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AdrBr, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(AdrBlr, assembler) {
+ __ movz(R0, 123, 0);
+ __ add(R3, ZR, Operand(LR)); // Save LR.
+ __ adr(R1, 4 * Instr::kInstrSize); // R1 <- PC + 4*Instr::kInstrSize
+ __ blr(R1);
+ __ add(LR, ZR, Operand(R3));
+ __ ret();
+
+ // blr goes here.
+ __ movz(R0, 42, 0);
+ __ ret();
+}
+
+
+ASSEMBLER_TEST_RUN(AdrBlr, test) {
+ typedef int (*SimpleCode)();
+ EXPECT_EQ(42, EXECUTE_TEST_CODE_INT64(SimpleCode, test->entry()));
+}
+
} // namespace dart
#endif // defined(TARGET_ARCH_ARM64)
« runtime/vm/assembler_arm64.h ('K') | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/constants_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698