Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2353623004: Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. (Closed)

Created:
4 years, 3 months ago by flackr
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Only paint the background onto the scrolling contents layer if we have a scrolling contents layer. TBR=chrishtr@chromium.org BUG=647169, 645949 TEST=CompositedLayerMappingTest.BackgroundPaintedIntoGraphicsLayerIfNotCompositedScrolling CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2346883003 Cr-Commit-Position: refs/heads/master@{#419064} (cherry picked from commit dd59f478410b76764e227fe24642bae6f7b06b26) Committed: https://chromium.googlesource.com/chromium/src/+/a88c6ad9ff6b006f496679107d484df9ca4782c6

Patch Set 1 #

Patch Set 2 : Use local background on test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 2 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
flackr
4 years, 3 months ago (2016-09-20 21:03:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a88c6ad9ff6b006f496679107d484df9ca4782c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698