Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3600)

Unified Diff: chrome/browser/ui/browser.h

Issue 23536075: Fix multiple problems with omnibox text handling across focus changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.h
===================================================================
--- chrome/browser/ui/browser.h (revision 224205)
+++ chrome/browser/ui/browser.h (working copy)
@@ -437,10 +437,10 @@
virtual void TabDetachedAt(content::WebContents* contents,
int index) OVERRIDE;
virtual void TabDeactivated(content::WebContents* contents) OVERRIDE;
- virtual void ActiveTabChanged(content::WebContents* old_contents,
- content::WebContents* new_contents,
- int index,
- int reason) OVERRIDE;
+ // We don't override ActiveTabChanged(); instead we expect a platform-specific
+ // TabStripModelObserver to call OnActiveTabChanged(). This allows the
+ // platform-specific handler to run first, which is important on views; see
+ // comments at the end of BrowserView::ActiveTabChanged().
virtual void TabMoved(content::WebContents* contents,
int from_index,
int to_index) OVERRIDE;
@@ -452,6 +452,12 @@
int index) OVERRIDE;
virtual void TabStripEmpty() OVERRIDE;
+ // This is the replacement for ActiveTabChanged() (see above).
+ void OnActiveTabChanged(content::WebContents* old_contents,
+ content::WebContents* new_contents,
+ int index,
+ int reason);
+
// Overridden from content::WebContentsDelegate:
virtual bool CanOverscrollContent() const OVERRIDE;
virtual bool PreHandleKeyboardEvent(
« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698