Fix read-after-free when loading two search engines with the same keyword.

Fix read-after-free when loading two search engines with the same keyword.

BUG=232657
TEST=none
R=beaudoin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223418

[beaudoin, 2013-09-14 03:24:03]

LGTM 1 nit

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service.cc (right):

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:1551:
std::partition(urls->begin(), urls->end(), HasValidID));
Clever use of partition!

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.h:625: // after calling; to
reinforce this, this function clears |urls| on exit.
Nit: |urls| --> |template_urls|

[Peter Kasting, 2013-09-16 21:10:12]

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/23536053/diff/17001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.h:625: // after calling; to
reinforce this, this function clears |urls| on exit.
On 2013/09/14 03:24:03, beaudoin wrote:
> Nit: |urls| --> |template_urls|

Done.

[Peter Kasting, 2013-09-16 21:22:31]

Committed patchset #2 manually as r223418 (presubmit successful).