Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 23536046: Try for better bench stability. (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

It looks like we're not always running long enough to give the GPU counters time to converge (and possibly the same for CPU too, but GPU is definitely worse off). This CL changes our convergence logic from - did the last run take more than x milliseconds? to - did the last run take more x milliseconds and are the last two runs within y% of each other? There's also now an upper limit where we bail out with an error if we haven't yet met the convergence criteria. Keeping the lower bound is important for benches where the constant overhead is much larger than the work done in the loop; without it we'll see T(1 loop) == T(2 loops) and converge way too early. This CL also exposed that DeferredCanvasBench had a bug: it was running N^2 loops when we told it to run N. (My fault.) I threw in a couple other linty changes that I'd be happy to split off. BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11267

Patch Set 1 #

Patch Set 2 : better candidate #

Patch Set 3 : linting #

Patch Set 4 : prefix up arrow #

Patch Set 5 : stray #

Patch Set 6 : tune default settings a bit more towards slower and more precise #

Total comments: 10

Patch Set 7 : review #

Patch Set 8 : review #

Patch Set 9 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
bench/DeferredCanvasBench.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -5 lines 0 comments Download
bench/benchmain.cpp View 1 2 3 4 5 6 7 6 chunks +42 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years, 3 months ago (2013-09-13 19:30:57 UTC) #1
robertphillips
lgtm + nits & a question https://codereview.chromium.org/23536046/diff/11001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/23536046/diff/11001/bench/benchmain.cpp#newcode551 bench/benchmain.cpp:551: You're sure about ...
7 years, 3 months ago (2013-09-13 20:00:59 UTC) #2
mtklein
https://codereview.chromium.org/23536046/diff/11001/bench/benchmain.cpp File bench/benchmain.cpp (right): https://codereview.chromium.org/23536046/diff/11001/bench/benchmain.cpp#newcode551 bench/benchmain.cpp:551: On 2013/09/13 20:00:59, robertphillips wrote: > You're sure about ...
7 years, 3 months ago (2013-09-13 20:07:46 UTC) #3
mtklein
7 years, 3 months ago (2013-09-13 20:11:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #9 manually as r11267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698