Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 23536045: ARM: Tweak the integer division operation. (Closed)

Created:
7 years, 3 months ago by Rodolph Perfetta
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Tweak the integer division operation. BUG=none TEST=test/mjsunit/lithium/DivI.js R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -27 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +24 lines, -14 lines 0 comments Download
A + test/mjsunit/lithium/DivI.js View 1 chunk +25 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta
On ARM there is no reason for the division to always overwrite its left input. ...
7 years, 3 months ago (2013-09-13 15:08:32 UTC) #1
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-16 06:17:57 UTC) #2
Rodolph Perfetta
7 years, 3 months ago (2013-09-16 11:28:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16727 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698