Issue 23536043: Merge 222614 "Change the PepperInProcessRouter to defer resource..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23536043: Merge 222614 "Change the PepperInProcessRouter to defer resource..." (Closed)

Created:
7 years, 3 months ago by bbudge

Modified:
7 years, 3 months ago

Reviewers:
bbudge

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 222614 "Change the PepperInProcessRouter to defer resource..." > Change the PepperInProcessRouter to defer resource destruction messages. > This changes the in process "proxy" so it posts tasks to send resource destruction messages > instead of calling them directly. This prevents several kinds of reentrancy into the plugin-side > code. In this case, when a URLLoader is released, the plugin can finish before the host cancels > the load and potentially deletes the instance. > > BUG=276368 > > Review URL: https://chromiumcodereview.appspot.com/23688004 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222786

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -3 lines)			Patch
	M	content/renderer/pepper/pepper_in_process_router.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/pepper/pepper_in_process_router.cc	View		2 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r222786.

Expand Messages | Collapse Messages