Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 23536042: Rebaseline fontscaler image for Mac 10.8 (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
epoger, bsalomon
CC:
skia-team_googlegroups.com
Visibility:
Public.

Description

Rebaseline fontscaler image for Mac 10.8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 3 months ago (2013-09-10 18:12:23 UTC) #1
epoger
https://codereview.chromium.org/23536042/diff/1/expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json File expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json (right): https://codereview.chromium.org/23536042/diff/1/expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json#newcode6973 expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json:6973: 3516231264404197043 So, do I have this right? The 6-column ...
7 years, 3 months ago (2013-09-10 18:17:41 UTC) #2
epoger
On 2013/09/10 18:17:41, epoger wrote: > https://codereview.chromium.org/23536042/diff/1/expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json > File > expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json > (right): > > ...
7 years, 3 months ago (2013-09-10 18:18:46 UTC) #3
epoger
LGTM On 2013/09/10 18:18:46, epoger wrote: > Or, given that "reviewed-by-human": false , we just ...
7 years, 3 months ago (2013-09-10 18:20:14 UTC) #4
robertphillips
Brian modified the test to remove the 6th column so it is expected that it ...
7 years, 3 months ago (2013-09-10 18:52:38 UTC) #5
robertphillips
7 years, 3 months ago (2013-09-10 18:55:41 UTC) #6
Message was sent while issue was closed.
committed as r11185

Powered by Google App Engine
This is Rietveld 408576698