|
|
Chromium Code Reviews|
Created:
7 years, 3 months ago by lgombos Modified:
7 years, 3 months ago Reviewers:
abarth-chromium CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionRemove all the NETBSD guards as we do not build nor test on NetBSD.
BUG=286645
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Rebase #
Messages
Total messages: 18 (0 generated)
I found NETBSD guards in blink so perhaps we should have it a global guard. Alternatively we should remove all NETBSD guards (with the exception of standalone projects e.g. v8.
On 2013/09/07 06:16:01, lgombos wrote: > I found NETBSD guards in blink so perhaps we should have it a global guard. > > Alternatively we should remove all NETBSD guards (with the exception of > standalone projects e.g. v8. I'd prefer to remove all the NETBSD guards. I'm not sure how we decide which flavors of Linux to support in trunk, but I don't think we build or test on NetBSD.
On 2013/09/07 07:06:28, abarth wrote: > I'd prefer to remove all the NETBSD guards. I'm not sure how we decide which > flavors of Linux to support in trunk, but I don't think we build or test on > NetBSD. Alright, I probably just offended all the NetBSD hackers out there. I meant flavors of Unix. :)
Remove NetBSD specific bits from blink
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/11001
Failed to apply patch for Source/config.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
A Source
Created missing directory Source.
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: Source/config.h
|diff --git a/Source/config.h b/Source/config.h
|index
00324eb63122587218708119e75e373c33b2f9aa..f850510d97cac497a984df8211212ca55de25395
100644
|--- a/Source/config.h
|+++ b/Source/config.h
--------------------------
No file to patch. Skipping patch.
2 out of 2 hunks ignored
Patch: Source/config.h
Index: Source/config.h
diff --git a/Source/config.h b/Source/config.h
index
00324eb63122587218708119e75e373c33b2f9aa..f850510d97cac497a984df8211212ca55de25395
100644
--- a/Source/config.h
+++ b/Source/config.h
@@ -66,11 +66,6 @@
#define WTF_OS_LINUX 1
#endif
-/* OS(NETBSD) - NetBSD */
-#if defined(__NetBSD__)
-#define WTF_OS_NETBSD 1
-#endif
-
/* OS(OPENBSD) - OpenBSD */
#ifdef __OpenBSD__
#define WTF_OS_OPENBSD 1
@@ -86,7 +81,6 @@
|| OS(DARWIN) \
|| OS(FREEBSD) \
|| OS(LINUX) \
- || OS(NETBSD) \
|| OS(OPENBSD) \
|| defined(unix) \
|| defined(__unix) \
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
Failed to apply patch for Source/config.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
A Source
Created missing directory Source.
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: Source/config.h
|diff --git a/Source/config.h b/Source/config.h
|index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
|--- a/Source/config.h
|+++ b/Source/config.h
--------------------------
No file to patch. Skipping patch.
2 out of 2 hunks ignored
Patch: Source/config.h
Index: Source/config.h
diff --git a/Source/config.h b/Source/config.h
index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
--- a/Source/config.h
+++ b/Source/config.h
@@ -66,11 +66,6 @@
#define WTF_OS_LINUX 1
#endif
-/* OS(NETBSD) - NetBSD */
-#if defined(__NetBSD__)
-#define WTF_OS_NETBSD 1
-#endif
-
/* OS(OPENBSD) - OpenBSD */
#ifdef __OpenBSD__
#define WTF_OS_OPENBSD 1
@@ -86,7 +81,6 @@
|| OS(MACOSX) \
|| OS(FREEBSD) \
|| OS(LINUX) \
- || OS(NETBSD) \
|| OS(OPENBSD) \
|| defined(unix) \
|| defined(__unix) \
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
Failed to apply patch for Source/config.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
A Source
Created missing directory Source.
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: Source/config.h
|diff --git a/Source/config.h b/Source/config.h
|index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
|--- a/Source/config.h
|+++ b/Source/config.h
--------------------------
No file to patch. Skipping patch.
2 out of 2 hunks ignored
Patch: Source/config.h
Index: Source/config.h
diff --git a/Source/config.h b/Source/config.h
index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
--- a/Source/config.h
+++ b/Source/config.h
@@ -66,11 +66,6 @@
#define WTF_OS_LINUX 1
#endif
-/* OS(NETBSD) - NetBSD */
-#if defined(__NetBSD__)
-#define WTF_OS_NETBSD 1
-#endif
-
/* OS(OPENBSD) - OpenBSD */
#ifdef __OpenBSD__
#define WTF_OS_OPENBSD 1
@@ -86,7 +81,6 @@
|| OS(MACOSX) \
|| OS(FREEBSD) \
|| OS(LINUX) \
- || OS(NETBSD) \
|| OS(OPENBSD) \
|| defined(unix) \
|| defined(__unix) \
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
Failed to apply patch for Source/config.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
A Source
Created missing directory Source.
can't find file to patch at input line 6
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: Source/config.h
|diff --git a/Source/config.h b/Source/config.h
|index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
|--- a/Source/config.h
|+++ b/Source/config.h
--------------------------
No file to patch. Skipping patch.
2 out of 2 hunks ignored
Patch: Source/config.h
Index: Source/config.h
diff --git a/Source/config.h b/Source/config.h
index
e1ffe922031cd0df2987ce88daf173b0c6c018fb..301ddad1fb8e063a892852405bc10a1d81edeb89
100644
--- a/Source/config.h
+++ b/Source/config.h
@@ -66,11 +66,6 @@
#define WTF_OS_LINUX 1
#endif
-/* OS(NETBSD) - NetBSD */
-#if defined(__NetBSD__)
-#define WTF_OS_NETBSD 1
-#endif
-
/* OS(OPENBSD) - OpenBSD */
#ifdef __OpenBSD__
#define WTF_OS_OPENBSD 1
@@ -86,7 +81,6 @@
|| OS(MACOSX) \
|| OS(FREEBSD) \
|| OS(LINUX) \
- || OS(NETBSD) \
|| OS(OPENBSD) \
|| defined(unix) \
|| defined(__unix) \
On 2013/09/09 05:02:20, I haz the power (commit-bot) wrote: > Failed to apply patch for Source/config.h: > While running patch -p1 --forward --force --no-backup-if-mismatch; > A Source > Created missing directory Source. Ahh.. The bot is trying to commit it to the main Chromium tree and not to the Blink tree as the first CL was for Chromium.. I will either have to commit it manually and create a new CL.
On 2013/09/09 05:21:16, lgombos wrote: > On 2013/09/09 05:02:20, I haz the power (commit-bot) wrote: > > Failed to apply patch for Source/config.h: > > While running patch -p1 --forward --force --no-backup-if-mismatch; > > A Source > > Created missing directory Source. > > Ahh.. The bot is trying to commit it to the main Chromium tree and not to the > Blink tree as the first CL was for Chromium.. I will either have to commit it > manually and create a new CL. Committed as r157441.
Message was sent while issue was closed.
Relatedly, we just had a discussion about this (number of cores) on Ninja. It turns out there's one call that works across all the BSDs and Linux, so this code can be made even simpler: https://github.com/martine/ninja/commit/4a72182c6c65d44f894da68a72fb797b34c8d9ec
Message was sent while issue was closed.
On 2013/09/11 18:29:25, Evan Martin wrote: > Relatedly, we just had a discussion about this (number of cores) on Ninja. It > turns out there's one call that works across all the BSDs and Linux, so this > code can be made even simpler: > > https://github.com/martine/ninja/commit/4a72182c6c65d44f894da68a72fb797b34c8d9ec Ooops, the discussion is here: https://github.com/martine/ninja/pull/647
Message was sent while issue was closed.
> Ooops, the discussion is here: > https://github.com/martine/ninja/pull/647 Fixed. https://codereview.chromium.org/23609031/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
