Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 23536039: Remove NetBSD specific bits from blink (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove all the NETBSD guards as we do not build nor test on NetBSD. BUG=286645

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M Source/config.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M Source/wtf/NumberOfCores.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
lgombos
I found NETBSD guards in blink so perhaps we should have it a global guard. ...
7 years, 3 months ago (2013-09-07 06:16:01 UTC) #1
abarth-chromium
On 2013/09/07 06:16:01, lgombos wrote: > I found NETBSD guards in blink so perhaps we ...
7 years, 3 months ago (2013-09-07 07:06:28 UTC) #2
abarth-chromium
On 2013/09/07 07:06:28, abarth wrote: > I'd prefer to remove all the NETBSD guards. I'm ...
7 years, 3 months ago (2013-09-07 07:06:58 UTC) #3
lgombos
Remove NetBSD specific bits from blink
7 years, 3 months ago (2013-09-07 22:04:12 UTC) #4
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-08 05:10:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/11001
7 years, 3 months ago (2013-09-08 05:10:58 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/config.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source ...
7 years, 3 months ago (2013-09-08 05:11:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
7 years, 3 months ago (2013-09-08 21:46:11 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/config.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source ...
7 years, 3 months ago (2013-09-08 21:46:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
7 years, 3 months ago (2013-09-09 00:19:03 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/config.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source ...
7 years, 3 months ago (2013-09-09 00:19:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23536039/19001
7 years, 3 months ago (2013-09-09 05:02:18 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/config.h: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source ...
7 years, 3 months ago (2013-09-09 05:02:20 UTC) #13
lgombos
On 2013/09/09 05:02:20, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
7 years, 3 months ago (2013-09-09 05:21:16 UTC) #14
lgombos
On 2013/09/09 05:21:16, lgombos wrote: > On 2013/09/09 05:02:20, I haz the power (commit-bot) wrote: ...
7 years, 3 months ago (2013-09-09 14:18:16 UTC) #15
Evan Martin
Relatedly, we just had a discussion about this (number of cores) on Ninja. It turns ...
7 years, 3 months ago (2013-09-11 18:29:25 UTC) #16
Evan Martin
On 2013/09/11 18:29:25, Evan Martin wrote: > Relatedly, we just had a discussion about this ...
7 years, 3 months ago (2013-09-11 18:29:47 UTC) #17
lgombos
7 years, 3 months ago (2013-09-13 03:57:49 UTC) #18
Message was sent while issue was closed.
> Ooops, the discussion is here:
> https://github.com/martine/ninja/pull/647

Fixed. 

https://codereview.chromium.org/23609031/

Powered by Google App Engine
This is Rietveld 408576698