Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 23536034: Set up hdmi output device default volume to 100. (Closed)

Created:
7 years, 3 months ago by jennyz
Modified:
7 years, 3 months ago
Reviewers:
rkc
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Set up hdmi output device default volume to 100. BUG=268438 TEST=hdmi output device should have maximum volume(100) be default. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222066

Patch Set 1 #

Patch Set 2 : Remove the default value of input gain. #

Total comments: 4

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -47 lines) Patch
M chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.cc View 1 2 4 chunks +48 lines, -16 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/audio/audio_devices_pref_handler_stub.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/audio/audio_devices_pref_handler_stub.cc View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jennyz
7 years, 3 months ago (2013-09-06 18:50:48 UTC) #1
jennyz
7 years, 3 months ago (2013-09-06 21:47:01 UTC) #2
jennyz
7 years, 3 months ago (2013-09-06 21:54:49 UTC) #3
rkc
https://codereview.chromium.org/23536034/diff/3001/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h File chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h (right): https://codereview.chromium.org/23536034/diff/3001/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h#newcode58 chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h:58: double GetDeviceDefaultOutputVolumeValue(const AudioDevice& device); nit: GetDeviceDefaultVolume should be file, ...
7 years, 3 months ago (2013-09-06 22:01:48 UTC) #4
rkc
lgtm modulo nits
7 years, 3 months ago (2013-09-06 22:02:21 UTC) #5
jennyz
https://codereview.chromium.org/23536034/diff/3001/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h File chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h (right): https://codereview.chromium.org/23536034/diff/3001/chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h#newcode58 chrome/browser/chromeos/audio/audio_devices_pref_handler_impl.h:58: double GetDeviceDefaultOutputVolumeValue(const AudioDevice& device); On 2013/09/06 22:01:48, Rahul Chaturvedi ...
7 years, 3 months ago (2013-09-06 22:50:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/23536034/15001
7 years, 3 months ago (2013-09-06 22:51:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76468
7 years, 3 months ago (2013-09-07 02:38:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/23536034/15001
7 years, 3 months ago (2013-09-09 17:28:21 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 18:54:43 UTC) #10
Message was sent while issue was closed.
Change committed as 222066

Powered by Google App Engine
This is Rietveld 408576698