Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: remoting/webapp/background.js

Issue 23536033: Add 'New window' option to context menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reviewer feedback and rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/appsv2.patch ('k') | remoting/webapp/jscompiler_hacks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/background.js
diff --git a/remoting/webapp/background.js b/remoting/webapp/background.js
index 290b43a0ee6929c268999f22f9a4494d3c049d8f..118b7e578809ff8f4d94bfaa87e7c015c82b4e88 100644
--- a/remoting/webapp/background.js
+++ b/remoting/webapp/background.js
@@ -2,9 +2,31 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-chrome.app.runtime.onLaunched.addListener(function() {
+/** @type {string} */
+var kNewWindowId = 'new-window';
+
+function createWindow() {
chrome.app.window.create('main.html', {
'width': 800,
'height': 600
});
-});
+};
+
+/** @param {OnClickData} info */
+function onContextMenu(info) {
+ if (info.menuItemId == kNewWindowId) {
+ createWindow();
+ }
+};
+
+function initializeContextMenu() {
+ chrome.contextMenus.create({
+ id: kNewWindowId,
+ contexts: ['launcher'],
+ title: chrome.i18n.getMessage(/*i18n-content*/'NEW_WINDOW')
+ });
+}
+
+chrome.app.runtime.onLaunched.addListener(createWindow);
+chrome.contextMenus.onClicked.addListener(onContextMenu);
+initializeContextMenu();
« no previous file with comments | « remoting/webapp/appsv2.patch ('k') | remoting/webapp/jscompiler_hacks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698