Fix typing of accented characters on the VK in Google Docs.

Fix typing of accented characters on the VK in Google Docs.

BUG=257093, 257098
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221768

[kevers, 2013-09-05 15:49:38]

Hi Sadrul,

Can you please take a look at this CL.

[sadrul, 2013-09-05 22:54:49]

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util....
ui/keyboard/keyboard_util.cc:25: void sendProcessKeyEvent(ui::EventType type,
aura::RootWindow* root_window) {
SendProcessKeyEvent

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util....
ui/keyboard/keyboard_util.cc:130: sendProcessKeyEvent(ui::ET_KEY_RELEASED,
root_window);
I think it'd be simpler if you do:

  SendProcessKeyEvent(....);
  InsertText(....);
  SendProcessKeyEvent(....);

Would that work?

[kevers, 2013-09-06 00:48:24]

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util....
ui/keyboard/keyboard_util.cc:25: void sendProcessKeyEvent(ui::EventType type,
aura::RootWindow* root_window) {
On 2013/09/05 22:54:49, sadrul wrote:
> SendProcessKeyEvent

Done.

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util....
ui/keyboard/keyboard_util.cc:130: sendProcessKeyEvent(ui::ET_KEY_RELEASED,
root_window);
On 2013/09/05 22:54:49, sadrul wrote:
> I think it'd be simpler if you do:
> 
>   SendProcessKeyEvent(....);
>   InsertText(....);
>   SendProcessKeyEvent(....);
> 
> Would that work?

InsertText does not work for web content as the text insertion appears before
the press event.  InsertChar yields the correct sequence of events, producing a
keypressed event between the keydown and keyup.

[sadrul, 2013-09-06 05:52:38]

LGTM

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util.cc
File ui/keyboard/keyboard_util.cc (right):

https://codereview.chromium.org/23536030/diff/2001/ui/keyboard/keyboard_util....
ui/keyboard/keyboard_util.cc:130: sendProcessKeyEvent(ui::ET_KEY_RELEASED,
root_window);
On 2013/09/06 00:48:25, kevers wrote:
> On 2013/09/05 22:54:49, sadrul wrote:
> > I think it'd be simpler if you do:
> > 
> >   SendProcessKeyEvent(....);
> >   InsertText(....);
> >   SendProcessKeyEvent(....);
> > 
> > Would that work?
> 
> InsertText does not work for web content as the text insertion appears before
> the press event.  InsertChar yields the correct sequence of events, producing
a
> keypressed event between the keydown and keyup.

Ah, I see. It feels a bit weird that InsertText() and InsertChar() don't
generate events in the same/similar sequence.

[commit-bot: I haz the power, 2013-09-06 13:41:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/23536030/8001

[commit-bot: I haz the power, 2013-09-06 20:19:32]

Change committed as 221768