Adds cache and buffer graphs to the properties pane.

ui/webui/resources/js/cr.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * The global object.
  * @type {!Object}
  * @const
  */
 var global = this;
@@ skipping 333 matching lines @@
     cr.isChromeOS = /CrOS/.test(navigator.userAgent);
 
     /**
      * Whether this is on vanilla Linux (not chromeOS).
      */
     cr.isLinux = /Linux/.test(navigator.userAgent);
 
     /**
      * Whether this uses GTK or not.
      */
-    cr.isGTK = typeof chrome.getVariableValue == 'function' &&
+    cr.isGTK = typeof chrome !== 'undefined' &&

[Ty Overby, 2013/09/09 17:45:55]

The reason for this check is that inside of a webui_resource_browsertest,
'chrome' is not defined.  To let cr.js work in this environment, a check here is
required. 

[scherkus (not reviewing), 2013/09/09 17:48:28]

To elaborate, content-based browsers (e.g., content_shell) can use
ui/webui/resources/js/* but won't necessarily define "chrome" APIs

[arv (Not doing code reviews), 2013/09/09 18:02:19]

Please add chrome to your test instead.

[Charlie Reis, 2013/09/09 18:02:22]

Can these thoughts be added as a comment in the code?

[Ty Overby, 2013/09/09 18:28:13]

See my comment in reply to your comment in main.js

+        typeof chrome.getVariableValue == 'function' &&
         /GTK/.test(chrome.getVariableValue('toolkit'));
 
     /**
      * Whether this uses the views toolkit or not.
      */
-    cr.isViews = typeof chrome.getVariableValue == 'function' &&
+    cr.isViews = typeof chrome !== 'undefined' &&
+        typeof chrome.getVariableValue == 'function' &&
         /views/.test(chrome.getVariableValue('toolkit'));
   }
 
   return {
     addSingletonGetter: addSingletonGetter,
     createUid: createUid,
     define: define,
     defineProperty: defineProperty,
     dispatchPropertyChange: dispatchPropertyChange,
     dispatchSimpleEvent: dispatchSimpleEvent,
     Event: Event,
     getUid: getUid,
     initialize: initialize,
     PropertyKind: PropertyKind
   };
 })();
 
 
 /**
  * TODO(kgr): Move this to another file which is to be loaded last.
  * This will be done as part of future work to make this code pre-compilable.
  */
 cr.initialize();