tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py - Issue 23536019: show_stdout to BrowserOptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 23536019: show_stdout to BrowserOptions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

index f57de5980badc038af0a9f4becaf4583e327b147..0af0a6ca8fca25c25778a02962f82c0d3eb16326 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

@@ -79,7 +79,7 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

env = os.environ.copy()

env['CHROME_HEADLESS'] = '1' # Don't upload minidumps.

env['BREAKPAD_DUMP_LOCATION'] = self._tmp_minidump_dir

- if not self.finder_options.show_stdout:

+ if not self.browser_options.show_stdout:

self._tmp_output_file = tempfile.NamedTemporaryFile('w', 0)

self._proc = subprocess.Popen(

args, stdout=self._tmp_output_file, stderr=subprocess.STDOUT, env=env)

« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/browser_options.py » ('j') | no next file with comments »