ash/launcher/launcher_tooltip_manager.cc - Issue 23536012: [ash] Hide tooltip when mouse button is pressed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/launcher/launcher_tooltip_manager.cc

Issue 23536012: [ash] Hide tooltip when mouse button is pressed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/launcher/launcher_tooltip_manager.cc

diff --git a/ash/launcher/launcher_tooltip_manager.cc b/ash/launcher/launcher_tooltip_manager.cc

index 2d92e0f5e3bb9c88901b068f92c2caf32c462e95..901330a07fb11f86438a5999e3caafbcc44a96cf 100644

--- a/ash/launcher/launcher_tooltip_manager.cc

+++ b/ash/launcher/launcher_tooltip_manager.cc

@@ -256,6 +256,12 @@ void LauncherTooltipManager::OnMouseEvent(ui::MouseEvent* event) {

DCHECK(view_);

DCHECK(launcher_view_);

+ // Pressing the mouse button anywhere should close the tooltip.

+ if (event->type() == ui::ET_MOUSE_PRESSED) {

+ CloseSoon();

+ return;

+ }

aura::Window* target = static_cast<aura::Window*>(event->target());

if (widget_->GetNativeWindow()->GetRootWindow() != target->GetRootWindow()) {

CloseSoon();