Issue 23536007: Add scriptId to StackTrace frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23536007: Add scriptId to StackTrace frames. (Closed)

Created:
7 years, 3 months ago by vsevik

Modified:
7 years, 3 months ago

Reviewers:
yurys, Toon Verwaest

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Add scriptId to StackTrace frames. BUG=v8:2865 R=verwaest@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16459

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -2 lines)			Patch
M	include/v8.h	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	2 chunks	+13 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+36 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsevik

yurys@: Could you please review this change? verwaest@: Could you please OWNER review this change?

7 years, 3 months ago (2013-08-30 11:44:04 UTC) #1

yurys

lgtm with comment https://codereview.chromium.org/23536007/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/23536007/diff/1/test/cctest/test-api.cc#newcode16677 test/cctest/test-api.cc:16677: scriptIdInStack[i] = stackTrace->GetFrame(i)->GetScriptId(); Instead of using ...

7 years, 3 months ago (2013-08-30 13:07:25 UTC) #2

yurys

7 years, 3 months ago (2013-08-30 14:55:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16459 (presubmit successful).

Expand Messages | Collapse Messages