Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2353573002: [Chromecast] Allow targets in //chromecast to depend on //media/mojo/clients. (Closed)

Created:
4 years, 3 months ago by slan
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Allow targets in //chromecast to depend on //media/mojo/clients. Internal Cast code requires that clients in remote processes access the mojo:media service. Allow targets in the //chromecast/ subdirectory to depend on client code. A pattern-match is used to obscure the structure of internal directories. BUG= Committed: https://crrev.com/8406717810569b784d50d9a907ac306586b5f6aa Cr-Commit-Position: refs/heads/master@{#419523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/mojo/clients/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
slan
PTAL!
4 years, 3 months ago (2016-09-19 16:41:05 UTC) #2
xhwang
lgtm
4 years, 3 months ago (2016-09-19 16:58:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353573002/1
4 years, 3 months ago (2016-09-19 18:59:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 19:05:50 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:02:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8406717810569b784d50d9a907ac306586b5f6aa
Cr-Commit-Position: refs/heads/master@{#419523}

Powered by Google App Engine
This is Rietveld 408576698