Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2353553004: Revert of Create Monochrome-specific repack() targets (Closed)

Created:
4 years, 3 months ago by Benoit L
Modified:
4 years, 3 months ago
Reviewers:
michaelbai, brettw, agrieve
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create Monochrome-specific repack() targets (patchset #5 id:80001 of https://codereview.chromium.org/2354803002/ ) Reason for revert: Breaks ARM64 downstream bot (crbug.com/648878). Original issue's description: > Create Monochrome-specific repack() targets > > This allows Monochrome.apk's .pak files to properly contain the > union of Chrome and WebView's .pak files. It also allows it to use > a target-specific resource whitelist. > > This change applies to resources.pak and chrome_100_percent.pak. A > change to language .pak files will come as a follow-up. > > BUG=641032, 634358 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/a5d84d504167c0fb7452dec22c7f024f8fcde072 > Cr-Commit-Position: refs/heads/master@{#419960} TBR=michaelbai@chromium.org,brettw@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641032, 634358, 648878 Committed: https://crrev.com/cb8045c8f3889b84f3d36e3280763018328a5f17 Cr-Commit-Position: refs/heads/master@{#420021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -177 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 4 chunks +23 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 5 chunks +2 lines, -66 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_paks.gni View 4 chunks +69 lines, -100 lines 0 comments Download
M chrome/test/BUILD.gn View 12 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Benoit L
Created Revert of Create Monochrome-specific repack() targets
4 years, 3 months ago (2016-09-21 09:11:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353553004/1
4 years, 3 months ago (2016-09-21 09:27:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:28:05 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb8045c8f3889b84f3d36e3280763018328a5f17 Cr-Commit-Position: refs/heads/master@{#420021}
4 years, 3 months ago (2016-09-21 09:31:16 UTC) #8
agrieve
4 years, 3 months ago (2016-09-21 14:07:14 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2357973002/ by agrieve@chromium.org.

The reason for reverting is: Will update when fixed..

Powered by Google App Engine
This is Rietveld 408576698