Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/browser/renderer_host/media/video_capture_manager_unittest.cc

Issue 235353002: Extract VideoCaptureDeviceFactory out of VideoCaptureDevice and use for File and FakeVCD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: perkj@ nit Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/video_capture_manager.cc ('k') | media/media.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/video_capture_manager_unittest.cc
diff --git a/content/browser/renderer_host/media/video_capture_manager_unittest.cc b/content/browser/renderer_host/media/video_capture_manager_unittest.cc
index 7f6376f086783fb7b91d97a686b67f9ebd82a190..6bae8bdf65fd58bb3e505dd600ce406f986d08ae 100644
--- a/content/browser/renderer_host/media/video_capture_manager_unittest.cc
+++ b/content/browser/renderer_host/media/video_capture_manager_unittest.cc
@@ -16,8 +16,7 @@
#include "content/browser/renderer_host/media/video_capture_controller_event_handler.h"
#include "content/browser/renderer_host/media/video_capture_manager.h"
#include "content/common/media/media_stream_options.h"
-#include "media/video/capture/fake_video_capture_device.h"
-#include "media/video/capture/video_capture_device.h"
+#include "media/video/capture/fake_video_capture_device_factory.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -79,8 +78,13 @@ class VideoCaptureManagerTest : public testing::Test {
message_loop_.reset(new base::MessageLoopForIO);
io_thread_.reset(new BrowserThreadImpl(BrowserThread::IO,
message_loop_.get()));
- vcm_ = new VideoCaptureManager();
- vcm_->UseFakeDevice();
+ vcm_ = new VideoCaptureManager(scoped_ptr<media::VideoCaptureDeviceFactory>(
+ new media::FakeVideoCaptureDeviceFactory()));
+ video_capture_device_factory_ =
+ static_cast<media::FakeVideoCaptureDeviceFactory*>(
+ vcm_->video_capture_device_factory());
+ const int32 kNumberOfFakeDevices = 2;
+ video_capture_device_factory_->set_number_of_devices(kNumberOfFakeDevices);
vcm_->Register(listener_.get(), message_loop_->message_loop_proxy().get());
frame_observer_.reset(new MockFrameObserver());
}
@@ -138,6 +142,7 @@ class VideoCaptureManagerTest : public testing::Test {
scoped_ptr<base::MessageLoop> message_loop_;
scoped_ptr<BrowserThreadImpl> io_thread_;
scoped_ptr<MockFrameObserver> frame_observer_;
+ media::FakeVideoCaptureDeviceFactory* video_capture_device_factory_;
private:
DISALLOW_COPY_AND_ASSIGN(VideoCaptureManagerTest);
@@ -205,7 +210,7 @@ TEST_F(VideoCaptureManagerTest, OpenTwice) {
TEST_F(VideoCaptureManagerTest, ConnectAndDisconnectDevices) {
StreamDeviceInfoArray devices;
int number_of_devices_keep =
- media::FakeVideoCaptureDevice::NumberOfFakeDevices();
+ video_capture_device_factory_->number_of_devices();
InSequence s;
EXPECT_CALL(*listener_, DevicesEnumerated(MEDIA_DEVICE_VIDEO_CAPTURE, _))
@@ -215,7 +220,7 @@ TEST_F(VideoCaptureManagerTest, ConnectAndDisconnectDevices) {
ASSERT_EQ(devices.size(), 2u);
// Simulate we remove 1 fake device.
- media::FakeVideoCaptureDevice::SetNumberOfFakeDevices(1);
+ video_capture_device_factory_->set_number_of_devices(1);
EXPECT_CALL(*listener_, DevicesEnumerated(MEDIA_DEVICE_VIDEO_CAPTURE, _))
.WillOnce(SaveArg<1>(&devices));
vcm_->EnumerateDevices(MEDIA_DEVICE_VIDEO_CAPTURE);
@@ -223,7 +228,7 @@ TEST_F(VideoCaptureManagerTest, ConnectAndDisconnectDevices) {
ASSERT_EQ(devices.size(), 1u);
// Simulate we add 2 fake devices.
- media::FakeVideoCaptureDevice::SetNumberOfFakeDevices(3);
+ video_capture_device_factory_->set_number_of_devices(3);
EXPECT_CALL(*listener_, DevicesEnumerated(MEDIA_DEVICE_VIDEO_CAPTURE, _))
.WillOnce(SaveArg<1>(&devices));
vcm_->EnumerateDevices(MEDIA_DEVICE_VIDEO_CAPTURE);
@@ -231,7 +236,7 @@ TEST_F(VideoCaptureManagerTest, ConnectAndDisconnectDevices) {
ASSERT_EQ(devices.size(), 3u);
vcm_->Unregister();
- media::FakeVideoCaptureDevice::SetNumberOfFakeDevices(number_of_devices_keep);
+ video_capture_device_factory_->set_number_of_devices(number_of_devices_keep);
}
// Enumerate devices and open the first, then check the list of supported
« no previous file with comments | « content/browser/renderer_host/media/video_capture_manager.cc ('k') | media/media.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698