Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.cc

Issue 235353002: Extract VideoCaptureDeviceFactory out of VideoCaptureDevice and use for File and FakeVCD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tommi@s nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.cc
diff --git a/content/browser/renderer_host/media/media_stream_manager.cc b/content/browser/renderer_host/media/media_stream_manager.cc
index 56bc43a25a75fafb2f086a1c22082e807001145d..1155f69aadadb1834ce9d04d011b994f29df5355 100644
--- a/content/browser/renderer_host/media/media_stream_manager.cc
+++ b/content/browser/renderer_host/media/media_stream_manager.cc
@@ -36,6 +36,9 @@
#include "media/audio/audio_manager_base.h"
#include "media/audio/audio_parameters.h"
#include "media/base/channel_layout.h"
+#include "media/base/media_switches.h"
+#include "media/video/capture/fake_video_capture_device_factory.h"
+#include "media/video/capture/file_video_capture_device_factory.h"
#include "url/gurl.h"
#if defined(OS_WIN)
@@ -1427,19 +1430,32 @@ void MediaStreamManager::InitializeDeviceManagersOnIOThread() {
audio_input_device_manager_ = new AudioInputDeviceManager(audio_manager_);
audio_input_device_manager_->Register(this, device_task_runner_);
- video_capture_manager_ = new VideoCaptureManager();
- video_capture_manager_->Register(this, device_task_runner_);
-
// We want to be notified of IO message loop destruction to delete the thread
// and the device managers.
io_loop_ = base::MessageLoop::current();
io_loop_->AddDestructionObserver(this);
+ // Use a Fake Audio Device and Fake/File Video Device Factory if the command
+ // line flags are present, otherwise use a normal device factory.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kUseFakeDeviceForMediaStream)) {
- DVLOG(1) << "Using fake device";
- UseFakeDevice();
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kUseFileForFakeVideoCapture)) {
+ video_capture_manager_ = new VideoCaptureManager(
+ scoped_ptr<media::VideoCaptureDeviceFactory>(
+ new media::FileVideoCaptureDeviceFactory()));
+ } else {
+ video_capture_manager_ = new VideoCaptureManager(
+ scoped_ptr<media::VideoCaptureDeviceFactory>(
+ new media::FakeVideoCaptureDeviceFactory()));
+ }
+ audio_input_device_manager()->UseFakeDevice();
+ } else {
+ video_capture_manager_ = new VideoCaptureManager(
+ scoped_ptr<media::VideoCaptureDeviceFactory>(
+ new media::VideoCaptureDeviceFactory()));
}
+ video_capture_manager_->Register(this, device_task_runner_);
}
void MediaStreamManager::Opened(MediaStreamType stream_type,
@@ -1791,12 +1807,6 @@ void MediaStreamManager::StopMediaStreamFromBrowser(const std::string& label) {
CancelRequest(label);
}
-void MediaStreamManager::UseFakeDevice() {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- video_capture_manager()->UseFakeDevice();
- audio_input_device_manager()->UseFakeDevice();
-}
-
void MediaStreamManager::UseFakeUI(scoped_ptr<FakeMediaStreamUIProxy> fake_ui) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
use_fake_ui_ = true;

Powered by Google App Engine
This is Rietveld 408576698