Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: media/video/capture/fake_video_capture_device_factory.cc

Issue 235353002: Extract VideoCaptureDeviceFactory out of VideoCaptureDevice and use for File and FakeVCD. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tommi@s comments. FakeVCD PopulateFormatRoster() removed, the list comes from unit tests. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/fake_video_capture_device_factory.cc
diff --git a/media/video/capture/fake_video_capture_device_factory.cc b/media/video/capture/fake_video_capture_device_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..eb9915ba535ccb1dbbbc366c7cb8e3b2449a592a
--- /dev/null
+++ b/media/video/capture/fake_video_capture_device_factory.cc
@@ -0,0 +1,49 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/video/capture/fake_video_capture_device_factory.h"
+
+#include "base/strings/stringprintf.h"
+#include "media/video/capture/fake_video_capture_device.h"
+
+namespace media {
+
+FakeVideoCaptureDeviceFactory::FakeVideoCaptureDeviceFactory() {}
+
+scoped_ptr<VideoCaptureDevice> FakeVideoCaptureDeviceFactory::Create(
+ const VideoCaptureDevice::Name& device_name) {
+ for (int32 n = 0; n < number_of_devices_; ++n) {
perkj_chrome 2014/04/24 14:43:32 size_t instead of int32 or just int.
mcasas 2014/04/24 20:20:26 int. size_t has troubles in Windows.
perkj_chrome 2014/04/25 08:43:31 ok but you use size_t in GetDeviceSupportedFormats
+ std::string possible_id = base::StringPrintf("/dev/video%d", n);
+ if (device_name.id().compare(possible_id) == 0)
+ return scoped_ptr<VideoCaptureDevice>(new FakeVideoCaptureDevice());
+ }
+ return scoped_ptr<VideoCaptureDevice>();
+}
+
+void FakeVideoCaptureDeviceFactory::GetDeviceNames(
+ VideoCaptureDevice::Names* const device_names) {
+ DCHECK(device_names->empty());
+ for (int32 n = 0; n < number_of_devices_; ++n) {
perkj_chrome 2014/04/24 14:43:32 dito
mcasas 2014/04/24 20:20:26 Done.
+ VideoCaptureDevice::Name name(base::StringPrintf("fake_device_%d", n),
+ base::StringPrintf("/dev/video%d", n));
+ device_names->push_back(name);
+ }
+}
+
+void FakeVideoCaptureDeviceFactory::GetDeviceSupportedFormats(
+ const VideoCaptureDevice::Name& device,
+ VideoCaptureFormats* supported_formats) {
+ const int frame_rate = 1000 / FakeVideoCaptureDevice::kFakeCaptureTimeoutMs;
+ const gfx::Size supported_sizes[] = {gfx::Size(320, 240),
+ gfx::Size(640, 480),
+ gfx::Size(1280, 720)};
+ supported_formats->clear();
+ for (size_t i = 0; i < arraysize(supported_sizes); ++i) {
+ supported_formats->push_back(VideoCaptureFormat(supported_sizes[i],
+ frame_rate,
+ media::PIXEL_FORMAT_I420));
+ }
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698