Extract VideoCaptureDeviceFactory out of VideoCaptureDevice and use for File and FakeVCD.

media/video/capture/video_capture_device_factory.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_H_
+#define MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_H_
+
+#include "media/video/capture/video_capture_device.h"
+
+namespace media {
+
+// VideoCaptureDeviceFactory is the abstract base class for creation of video
+// capture devices in the different platforms. Derived classes are created and
+// owned by VideoCaptureManager in IO Thread.

[perkj_chrome, 2014/04/17 08:39:09]

So this is obviously not true
VideoCaptureManager::GetAvailableDevicesInfoOnDeviceThread(. 
Please add thread checks in the default implementation and update this comment.

[mcasas, 2014/04/23 06:20:28]

Correct, factory lives and operates in Device Thread, a.k.a. Audio Thread.
Done.

+class MEDIA_EXPORT VideoCaptureDeviceFactory {
+ public:
+  VideoCaptureDeviceFactory() {};
+  virtual ~VideoCaptureDeviceFactory() {};
+
+  // Creates a VideoCaptureDevice object. Returns NULL if something goes wrong.
+  // TODO(mcasas): Return a scoped_ptr to make ownership explicit.

[perkj_chrome, 2014/04/17 08:39:09]

This is a new class. Why leave this as a TODO?

[mcasas, 2014/04/23 06:20:28]

Changed here to scoped_ptr<> since it clarifies ownership of
the created VCD.

+  virtual VideoCaptureDevice* Create(
+      const VideoCaptureDevice::Name& device_name);
+
+  // Gets the names of all video capture devices connected to this computer.
+  virtual void GetDeviceNames(VideoCaptureDevice::Names* device_names);
+
+  // Gets the supported formats of a particular device attached to the system.
+  // This method should be called before allocating or starting a device. In
+  // case format enumeration is not supported, or there was a problem, the
+  // formats array will be empty.
+  virtual void GetDeviceSupportedFormats(
+      const VideoCaptureDevice::Name& device,
+      VideoCaptureFormats* supported_formats);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(VideoCaptureDeviceFactory);
+};
+
+}  // namespace media
+
+#endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_H_