Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1979)

Issue 2353513006: [TypeFeedbackVector] Properly ignore binary/compare op slots for FCG. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TypeFeedbackVector] Properly ignore binary/compare op slots for FCG. Fix a typo in TypeFeedbackVector::ComputeCounts, where we would not skip the interpreter binary/compare op IC slots for fullcodegen, and thus mess up the heuristics for tearing up. TBR=mvstanton@chromium.org Committed: https://crrev.com/c819a1e2280b3eb47dcc2e87ee80068de7f0ebe8 Cr-Commit-Position: refs/heads/master@{#39560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/type-feedback-vector-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-20 17:21:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353513006/1
4 years, 3 months ago (2016-09-20 17:21:27 UTC) #6
Benedikt Meurer
Hey Michael, Here's the quickfix for the typo in ComputeCounts :-) -- Benedikt
4 years, 3 months ago (2016-09-20 17:21:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 17:48:56 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 17:49:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c819a1e2280b3eb47dcc2e87ee80068de7f0ebe8
Cr-Commit-Position: refs/heads/master@{#39560}

Powered by Google App Engine
This is Rietveld 408576698