Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2353513005: MD Settings: Fix restart buttons for Chrome OS (Closed)

Created:
4 years, 3 months ago by michaelpg
Modified:
4 years, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix restart buttons for Chrome OS BUG=629009 R=tommycli@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5cf8f1a94abba8eaf1b652dc15520b36cf165fb4 Cr-Commit-Position: refs/heads/master@{#419936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/resources/settings/languages_page/language_detail_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/lifetime_browser_proxy.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/test_lifetime_browser_proxy.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
michaelpg
Tommy, can you take a look? Fixes restart on CrOS... not sure when the JS ...
4 years, 3 months ago (2016-09-20 02:53:50 UTC) #2
tommycli
lgtm thanks!
4 years, 3 months ago (2016-09-20 17:38:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353513005/1
4 years, 3 months ago (2016-09-20 20:05:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/301048)
4 years, 3 months ago (2016-09-20 20:55:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353513005/1
4 years, 3 months ago (2016-09-20 21:05:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/282942)
4 years, 3 months ago (2016-09-20 22:11:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353513005/1
4 years, 3 months ago (2016-09-21 00:57:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 01:49:10 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 01:52:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cf8f1a94abba8eaf1b652dc15520b36cf165fb4
Cr-Commit-Position: refs/heads/master@{#419936}

Powered by Google App Engine
This is Rietveld 408576698