third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2353513003: [css-grid] Use grid area position to determine overflowing items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2353513003: [css-grid] Use grid area position to determine overflowing items (Closed)

Patch Set: Patch Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index b83b4fc3ee18a680b8d1ed31a73e50436f0ff737..90a906943bc7771e8ee9cf0b3c659f27cb7605d5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -177,6 +177,7 @@ private:

LayoutUnit rowAxisOffsetForChild(const LayoutBox&, GridSizingData&) const;

LayoutUnit columnAxisOffsetForChild(const LayoutBox&, GridSizingData&) const;

ContentAlignmentData computeContentPositionAndDistributionOffset(GridTrackSizingDirection, const LayoutUnit& availableFreeSpace, unsigned numberOfGridTracks) const;

+ LayoutPoint gridAreaLogicalPosition(const GridArea&) const;

LayoutPoint findChildLogicalPosition(const LayoutBox&, GridSizingData&) const;

GridArea cachedGridArea(const LayoutBox&) const;

GridSpan cachedGridSpan(const LayoutBox&, GridTrackSizingDirection) const;