Remove handling in inspector for Object.observe async task events

Remove handling in inspector for Object.observe async task events

Committed: https://crrev.com/f322d3ad5ca2f02b612d6e263813b14cb0d3a1d1
Cr-Commit-Position: refs/heads/master@{#39601}

[Dan Ehrenberg, 2016-09-20 22:16:59]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org, kozyatinskiy@chromium.org

[Dan Ehrenberg, 2016-09-20 22:17:02]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-20 22:20:03]

https://codereview.chromium.org/2353503006/diff/1/src/inspector/V8Debugger.cpp
File src/inspector/V8Debugger.cpp (right):

https://codereview.chromium.org/2353503006/diff/1/src/inspector/V8Debugger.cp...
src/inspector/V8Debugger.cpp:656: void* ptr = reinterpret_cast<void*>(id * 2 +
1);
This used to be

id * 4 + 3

now it's

id * 2 + 1

Why should the 4 change to a 2?

[Dan Ehrenberg, 2016-09-20 22:21:58]

https://codereview.chromium.org/2353503006/diff/1/src/inspector/V8Debugger.cpp
File src/inspector/V8Debugger.cpp (right):

https://codereview.chromium.org/2353503006/diff/1/src/inspector/V8Debugger.cp...
src/inspector/V8Debugger.cpp:656: void* ptr = reinterpret_cast<void*>(id * 2 +
1);
On 2016/09/20 at 22:20:03, adamk wrote:
> This used to be
> 
> id * 4 + 3
> 
> now it's
> 
> id * 2 + 1
> 
> Why should the 4 change to a 2?

They were all given odd numbers. It used to alternate between Promises and
Object.observe callbacks; I just made the whole space be used by Promises
instead. This is the minimal formula to meet the non-aligned requirement. id * 4
+ 3 would be an obscure historical complication.

[adamk, 2016-09-20 22:23:42]

lgtm (thanks for the O.o cleanup), but kozyatinskiy should confirm as I'm not
familiar with the Blink side of this.

[commit-bot: I haz the power, 2016-09-20 22:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:49:30]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-09-21 15:05:31]

lgtm

[Dan Ehrenberg, 2016-09-21 15:44:09]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-09-21 15:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 15:46:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 15:47:35]

Description was changed from

==========
Remove handling in inspector for Object.observe async task events
==========

to

==========
Remove handling in inspector for Object.observe async task events

Committed: https://crrev.com/f322d3ad5ca2f02b612d6e263813b14cb0d3a1d1
Cr-Commit-Position: refs/heads/master@{#39601}
==========

[commit-bot: I haz the power, 2016-09-21 15:47:35]

Patchset 1 (id:??) landed as
https://crrev.com/f322d3ad5ca2f02b612d6e263813b14cb0d3a1d1
Cr-Commit-Position: refs/heads/master@{#39601}