third_party/WebKit/Source/modules/sensor/Sensor.h - Issue 2353493002: [Sensors] Allow Sensor API only on secure top-level browsing contexts and add frequency checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2353493002: [Sensors] Allow Sensor API only on secure top-level browsing contexts and add frequency checks (Closed)

Patch Set: Comments from Tim Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/Sensor.h

diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h

index cb7cb8be2e459a6c4daa5b3742d6988b7c93f238..39c21752c7fd804a63ce6ba4851c1b69e9c7961c 100644

--- a/third_party/WebKit/Source/modules/sensor/Sensor.h

+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h

@@ -64,7 +64,7 @@ public:

DECLARE_VIRTUAL_TRACE();

protected:

- Sensor(ExecutionContext*, const SensorOptions&, device::mojom::blink::SensorType);

+ Sensor(ScriptState*, const SensorOptions&, ExceptionState&, device::mojom::blink::SensorType);

virtual SensorReading* createSensorReading(SensorProxy*) = 0;

using SensorConfigurationPtr = device::mojom::blink::SensorConfigurationPtr;