Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: device/generic_sensor/public/cpp/platform_sensor_configuration.h

Issue 2353493002: [Sensors] Allow Sensor API only on secure top-level browsing contexts and add frequency checks (Closed)
Patch Set: Comments from Tim Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_GENERIC_SENSOR_PLATFORM_SENSOR_CONFIGURATION_H_ 5 #ifndef DEVICE_GENERIC_SENSOR_PLATFORM_SENSOR_CONFIGURATION_H_
6 #define DEVICE_GENERIC_SENSOR_PLATFORM_SENSOR_CONFIGURATION_H_ 6 #define DEVICE_GENERIC_SENSOR_PLATFORM_SENSOR_CONFIGURATION_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace device { 10 namespace device {
11 11
12 class PlatformSensorConfiguration { 12 class PlatformSensorConfiguration {
13 public: 13 public:
14 PlatformSensorConfiguration(); 14 PlatformSensorConfiguration();
15 explicit PlatformSensorConfiguration(double frequency); 15 explicit PlatformSensorConfiguration(double frequency);
16 ~PlatformSensorConfiguration(); 16 ~PlatformSensorConfiguration();
17 17
18 bool operator==(const PlatformSensorConfiguration& other) const; 18 bool operator==(const PlatformSensorConfiguration& other) const;
19 19
20 // Platform dependent implementations can override this operator if different 20 // Platform dependent implementations can override this operator if different
21 // optimal configuration comparison is required. By default, only frequency is 21 // optimal configuration comparison is required. By default, only frequency is
22 // used to compare two configurations. 22 // used to compare two configurations.
23 virtual bool operator>(const PlatformSensorConfiguration& other) const; 23 virtual bool operator>(const PlatformSensorConfiguration& other) const;
24 24
25 void set_frequency(double frequency) { 25 void set_frequency(double frequency);
26 DCHECK(frequency_ <= kMaxAllowedFrequency && frequency_ > 0.0);
27 frequency_ = frequency;
28 }
29
30 double frequency() const { return frequency_; } 26 double frequency() const { return frequency_; }
31 27
32 static constexpr double kMaxAllowedFrequency = 60.0;
33
34 private: 28 private:
35 double frequency_ = 1.0; // 1 Hz by default. 29 double frequency_ = 1.0; // 1 Hz by default.
36 }; 30 };
37 31
38 } // namespace device 32 } // namespace device
39 33
40 #endif // DEVICE_SENSORS_PLATFORM_SENSOR_CONFIGURATION_H_ 34 #endif // DEVICE_SENSORS_PLATFORM_SENSOR_CONFIGURATION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698