Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: infra/bots/recipe_modules/flavor/api.py

Issue 2353483003: Delete unused coverage recipe code. (Closed)
Patch Set: tools/ too Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/coverage_flavor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 10
11 from . import android_flavor 11 from . import android_flavor
12 from . import cmake_flavor 12 from . import cmake_flavor
13 from . import coverage_flavor
14 from . import default_flavor 13 from . import default_flavor
15 from . import gn_android_flavor 14 from . import gn_android_flavor
16 from . import gn_flavor 15 from . import gn_flavor
17 from . import ios_flavor 16 from . import ios_flavor
18 from . import pdfium_flavor 17 from . import pdfium_flavor
19 from . import valgrind_flavor 18 from . import valgrind_flavor
20 19
21 20
22 TEST_EXPECTED_SKP_VERSION = '42' 21 TEST_EXPECTED_SKP_VERSION = '42'
23 TEST_EXPECTED_SVG_VERSION = '42' 22 TEST_EXPECTED_SVG_VERSION = '42'
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 if is_android(builder_cfg): 66 if is_android(builder_cfg):
68 return android_flavor.AndroidFlavorUtils(self.m) 67 return android_flavor.AndroidFlavorUtils(self.m)
69 elif is_cmake(builder_cfg): 68 elif is_cmake(builder_cfg):
70 return cmake_flavor.CMakeFlavorUtils(self.m) 69 return cmake_flavor.CMakeFlavorUtils(self.m)
71 elif is_ios(builder_cfg): 70 elif is_ios(builder_cfg):
72 return ios_flavor.iOSFlavorUtils(self.m) 71 return ios_flavor.iOSFlavorUtils(self.m)
73 elif is_pdfium(builder_cfg): 72 elif is_pdfium(builder_cfg):
74 return pdfium_flavor.PDFiumFlavorUtils(self.m) 73 return pdfium_flavor.PDFiumFlavorUtils(self.m)
75 elif is_valgrind(builder_cfg): 74 elif is_valgrind(builder_cfg):
76 return valgrind_flavor.ValgrindFlavorUtils(self.m) 75 return valgrind_flavor.ValgrindFlavorUtils(self.m)
77 elif builder_cfg.get('configuration') == 'Coverage':
78 return coverage_flavor.CoverageFlavorUtils(self.m)
79 else: 76 else:
80 return default_flavor.DefaultFlavorUtils(self.m) 77 return default_flavor.DefaultFlavorUtils(self.m)
81 78
82 def setup(self): 79 def setup(self):
83 self._f = self.get_flavor(self.m.vars.builder_cfg) 80 self._f = self.get_flavor(self.m.vars.builder_cfg)
84 81
85 def step(self, name, cmd, **kwargs): 82 def step(self, name, cmd, **kwargs):
86 return self._f.step(name, cmd, **kwargs) 83 return self._f.step(name, cmd, **kwargs)
87 84
88 def compile(self, target, **kwargs): 85 def compile(self, target, **kwargs):
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 version, 223 version,
227 VERSION_FILE_SVG, 224 VERSION_FILE_SVG,
228 self.m.vars.tmp_dir, 225 self.m.vars.tmp_dir,
229 self.m.vars.local_svg_dir, 226 self.m.vars.local_svg_dir,
230 self.device_dirs.svg_dir, 227 self.device_dirs.svg_dir,
231 test_expected_version=self.m.properties.get( 228 test_expected_version=self.m.properties.get(
232 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION), 229 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION),
233 test_actual_version=self.m.properties.get( 230 test_actual_version=self.m.properties.get(
234 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION)) 231 'test_downloaded_svg_version', TEST_EXPECTED_SVG_VERSION))
235 return version 232 return version
OLDNEW
« no previous file with comments | « no previous file | infra/bots/recipe_modules/flavor/coverage_flavor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698