Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2353463003: Update ui_unscaled_resources.rc comment (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org Committed: https://crrev.com/c26e1ecfd3536bfa230924422d5087d61cfe04cb Cr-Commit-Position: refs/heads/master@{#419894}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/resources/BUILD.gn View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
brettw
4 years, 3 months ago (2016-09-19 21:24:07 UTC) #1
sky
LGTM
4 years, 3 months ago (2016-09-19 22:53:33 UTC) #6
brettw
It turns out this is used after all so I've changed this patch to just ...
4 years, 3 months ago (2016-09-20 17:33:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353463003/20001
4 years, 3 months ago (2016-09-20 17:34:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/144742)
4 years, 3 months ago (2016-09-20 18:51:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353463003/20001
4 years, 3 months ago (2016-09-20 19:16:21 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/144861)
4 years, 3 months ago (2016-09-20 21:08:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353463003/20001
4 years, 3 months ago (2016-09-20 22:24:47 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 23:22:58 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:24:51 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c26e1ecfd3536bfa230924422d5087d61cfe04cb
Cr-Commit-Position: refs/heads/master@{#419894}

Powered by Google App Engine
This is Rietveld 408576698