|
|
Chromium Code Reviews
DescriptionUpdate ui_unscaled_resources.rc comment
This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment.
R=sky@chromium.org
Committed: https://crrev.com/c26e1ecfd3536bfa230924422d5087d61cfe04cb
Cr-Commit-Position: refs/heads/master@{#419894}
Patch Set 1 #Patch Set 2 : Fix #Messages
Total messages: 23 (13 generated)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM
Description was changed from ========== Remove ui_unscaled_resources.rc from generated files. This file was produced by Grit but was not used. The GYP build expected it to be generated in a certain place, but now that it's gone, we can remove the references to it. R=sky@chromium.org ========== to ========== Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org ==========
It turns out this is used after all so I've changed this patch to just delete the comment.
The CQ bit was checked by brettw@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/2353463003/#ps20001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org ========== to ========== Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org ========== to ========== Update ui_unscaled_resources.rc comment This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org Committed: https://crrev.com/c26e1ecfd3536bfa230924422d5087d61cfe04cb Cr-Commit-Position: refs/heads/master@{#419894} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c26e1ecfd3536bfa230924422d5087d61cfe04cb Cr-Commit-Position: refs/heads/master@{#419894} |
