SkASSERT firing because pointer wraps negative.

SkASSERT firing because pointer wraps negative.

Some pointers are being cast to intptr_t so they can be used with
SkAlign8(). However, a large pointer value might become a negative
integer since intptr_t is signed.

When comparing these intptr_ts, we expect the larger pointer value to be
greater. But it might be so large that it becomes negative, causing it
to be less than.

A SkASSERT is firing for this exact reason.

BUG=648452
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353453004

Committed: https://skia.googlesource.com/skia/+/05a3eac35c58295caf5937da42c32da540b05cb0

[cblume, 2016-09-19 23:28:00]

Description was changed from

==========
SkASSERT firing because pointer wraps negative.

Some pointers are being cast to intptr_t so they can be used with
SkAlign8(). However, a large pointer value might become a negative
integer since intptr_t is signed.

When comparing these intptr_ts, we expect the larger pointer value to be
greater. But it might be so large that it becomes negative, causing it
to be less than.

A SkASSERT is firing for this exact reason.

BUG=648452
==========

to

==========
SkASSERT firing because pointer wraps negative.

Some pointers are being cast to intptr_t so they can be used with
SkAlign8(). However, a large pointer value might become a negative
integer since intptr_t is signed.

When comparing these intptr_ts, we expect the larger pointer value to be
greater. But it might be so large that it becomes negative, causing it
to be less than.

A SkASSERT is firing for this exact reason.

BUG=648452
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353453004
==========

[cblume, 2016-09-19 23:28:19]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:28:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cblume, 2016-09-19 23:28:35]

cblume@chromium.org changed reviewers:
+ bsalomon@google.com, ericrk@chromium.org

[cblume, 2016-09-19 23:28:35]

PTAL

[ericrk, 2016-09-20 00:14:17]

It's unfortunate that the SkAlign macros won't just work with a char*, but given
this restriction, there are trade-offs either way (using char* or using
uintptr_t). This LGTM.

[commit-bot: I haz the power, 2016-09-20 00:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:14:58]

Dry run: This issue passed the CQ dry run.

[ericrk, 2016-09-20 00:16:10]

On 2016/09/20 00:14:17, ericrk wrote:
> It's unfortunate that the SkAlign macros won't just work with a char*, but
given
> this restriction, there are trade-offs either way (using char* or using
> uintptr_t). This LGTM.

Also, thanks for the quick turnaround on this!

[bsalomon, 2016-09-20 02:59:59]

lgtm

[cblume, 2016-09-20 04:04:14]

The CQ bit was checked by cblume@chromium.org

[commit-bot: I haz the power, 2016-09-20 04:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 04:05:19]

Description was changed from

==========
SkASSERT firing because pointer wraps negative.

Some pointers are being cast to intptr_t so they can be used with
SkAlign8(). However, a large pointer value might become a negative
integer since intptr_t is signed.

When comparing these intptr_ts, we expect the larger pointer value to be
greater. But it might be so large that it becomes negative, causing it
to be less than.

A SkASSERT is firing for this exact reason.

BUG=648452
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353453004
==========

to

==========
SkASSERT firing because pointer wraps negative.

Some pointers are being cast to intptr_t so they can be used with
SkAlign8(). However, a large pointer value might become a negative
integer since intptr_t is signed.

When comparing these intptr_ts, we expect the larger pointer value to be
greater. But it might be so large that it becomes negative, causing it
to be less than.

A SkASSERT is firing for this exact reason.

BUG=648452
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353453004

Committed:
https://skia.googlesource.com/skia/+/05a3eac35c58295caf5937da42c32da540b05cb0
==========

[commit-bot: I haz the power, 2016-09-20 04:05:20]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/05a3eac35c58295caf5937da42c32da540b05cb0

[hal.canary, 2016-09-20 17:41:43]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-09-20 17:41:43]

Nit:
Your commit message exactly describes the bug you are fixing. You don't actually
say that you make any changes or fix the bug.

[cblume, 2016-09-20 17:46:00]

On 2016/09/20 17:41:43, Hal Canary wrote:
> Nit:
> Your commit message exactly describes the bug you are fixing. You don't
actually
> say that you make any changes or fix the bug.

Hrmmm you are right. I'll try to be better about that in the future.