Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2353433002: Use configurations and declared variables to select import/export URIs during prelinking. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use configurations and declared variables to select import/export URIs during prelinking. R=paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/27045 Committed: https://github.com/dart-lang/sdk/commit/f5a616834ea322eecfef4a0b705b9a195d8204dd

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cache selected URI. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -34 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 6 chunks +26 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 3 chunks +11 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 8 chunks +38 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +9 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +119 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 3 chunks +11 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
4 years, 3 months ago (2016-09-18 01:36:59 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2353433002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2353433002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4080 pkg/analyzer/lib/src/dart/element/element.dart:4080: return _selectUri( For efficiency we should cache this ...
4 years, 3 months ago (2016-09-18 13:46:49 UTC) #3
scheglov
https://codereview.chromium.org/2353433002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2353433002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4080 pkg/analyzer/lib/src/dart/element/element.dart:4080: return _selectUri( On 2016/09/18 13:46:49, Paul Berry wrote: > ...
4 years, 3 months ago (2016-09-18 21:03:48 UTC) #4
scheglov
4 years, 3 months ago (2016-09-18 21:04:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f5a616834ea322eecfef4a0b705b9a195d8204dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698