Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2353423002: [layoutng] Make sure to force child layout for the legacy/ng interop (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Make sure to force child layout for the legacy/ng interop We need to force this because the override size may have changed since last time. R=eae@chromium.org,mstensho@opera.com,glebl@chromium.org BUG=635619 Committed: https://crrev.com/c956496f471a2d9a826ed289201dd0a9e93f0e05 Cr-Commit-Position: refs/heads/master@{#420159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
cbiesinger
4 years, 3 months ago (2016-09-21 19:19:12 UTC) #1
mstensho (USE GERRIT)
lgtm. I'd like a test, but if that's too cumbersome at the moment, maybe just ...
4 years, 3 months ago (2016-09-21 20:44:54 UTC) #6
cbiesinger
LayoutTests/fast/css/begin-end-contain-selector-empty-value.html shows the problem
4 years, 3 months ago (2016-09-21 20:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353423002/1
4 years, 3 months ago (2016-09-21 20:46:38 UTC) #9
mstensho (USE GERRIT)
On 2016/09/21 20:46:04, cbiesinger wrote: > LayoutTests/fast/css/begin-end-contain-selector-empty-value.html shows the > problem Thanks!
4 years, 3 months ago (2016-09-21 20:49:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 20:52:27 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c956496f471a2d9a826ed289201dd0a9e93f0e05 Cr-Commit-Position: refs/heads/master@{#420159}
4 years, 3 months ago (2016-09-21 20:55:15 UTC) #13
eae
4 years, 3 months ago (2016-09-22 07:21:05 UTC) #14
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698