components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc - Issue 2353413002: Store list information in ListInfo (was: StoreIdAndFIleName)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

Issue 2353413002: Store list information in ListInfo (was: StoreIdAndFIleName) (Closed)

Patch Set: sort the members of ListInfo by member name Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/safe_browsing_db/v4_get_hash_protocol_manager.cc ('k') | components/safe_browsing_db/v4_local_database_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc b/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

index b8c8bff730bbc60bc0bd2abafdc66ab9759ffc4a..c8b0542e351a462cc69e67d041e4a14b042df87e 100644

--- a/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc

@@ -140,9 +140,9 @@ class V4GetHashProtocolManagerTest : public PlatformTest {

res.mutable_negative_cache_duration()->set_seconds(600);

for (const ResponseInfo& info : response_infos) {

ThreatMatch* m = res.add_matches();

- m->set_platform_type(info.list_id.platform_type);

- m->set_threat_entry_type(info.list_id.threat_entry_type);

- m->set_threat_type(info.list_id.threat_type);

+ m->set_platform_type(info.list_id.platform_type());

+ m->set_threat_entry_type(info.list_id.threat_entry_type());

+ m->set_threat_type(info.list_id.threat_type());

m->mutable_cache_duration()->set_seconds(300);

m->mutable_threat()->set_hash(info.full_hash);