Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: LayoutTests/editing/spelling/delete-misspelled-word.html

Issue 23534071: Use shouldBecomeEqual in asynchronous spellchecking tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Apply Tony's review and use asynchronous spellchecking in two tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/editing/spelling/delete-misspelled-word-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/editing/spelling/delete-misspelled-word.html
diff --git a/LayoutTests/editing/spelling/delete-misspelled-word.html b/LayoutTests/editing/spelling/delete-misspelled-word.html
index b3ae196f00d3b72a47e657ca9df18a63c713f0fe..d297391bfea1fb5063a836b5f7363df190ac0e1b 100644
--- a/LayoutTests/editing/spelling/delete-misspelled-word.html
+++ b/LayoutTests/editing/spelling/delete-misspelled-word.html
@@ -28,17 +28,7 @@ testRunner.execCommand("DeleteBackward");
testRunner.execCommand("DeleteBackward");
document.execCommand("InsertText", false, ' ');
-var retryCount = 10;
-function verifyMarker() {
- var hasMarker = internals.hasSpellingMarker(document, 0, 1);
- if (hasMarker && --retryCount > 0) {
- window.setTimeout(verifyMarker, 1);
- return;
- }
- shouldBeFalse('internals.hasSpellingMarker(document, 0, 1)');
- finishJSTest();
-}
-window.setTimeout(verifyMarker, 1);
+shouldBecomeEqual('internals.hasSpellingMarker(document, 0, 1)', 'false', finishJSTest);
</script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/editing/spelling/delete-misspelled-word-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698