LayoutTests/editing/spelling/delete-misspelled-word.html - Issue 23534071: Use shouldBecomeEqual in asynchronous spellchecking tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/spelling/delete-misspelled-word.html

Issue 23534071: Use shouldBecomeEqual in asynchronous spellchecking tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/editing/spelling/delete-misspelled-word-expected.txt » ('j') | LayoutTests/editing/spelling/grammar-markers.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/spelling/delete-misspelled-word.html

diff --git a/LayoutTests/editing/spelling/delete-misspelled-word.html b/LayoutTests/editing/spelling/delete-misspelled-word.html

index b3ae196f00d3b72a47e657ca9df18a63c713f0fe..d297391bfea1fb5063a836b5f7363df190ac0e1b 100644

--- a/LayoutTests/editing/spelling/delete-misspelled-word.html

+++ b/LayoutTests/editing/spelling/delete-misspelled-word.html

@@ -28,17 +28,7 @@ testRunner.execCommand("DeleteBackward");

testRunner.execCommand("DeleteBackward");

document.execCommand("InsertText", false, ' ');

-var retryCount = 10;

-function verifyMarker() {

- var hasMarker = internals.hasSpellingMarker(document, 0, 1);

- if (hasMarker && --retryCount > 0) {

- window.setTimeout(verifyMarker, 1);

- return;

- }

- shouldBeFalse('internals.hasSpellingMarker(document, 0, 1)');

- finishJSTest();

-window.setTimeout(verifyMarker, 1);

+shouldBecomeEqual('internals.hasSpellingMarker(document, 0, 1)', 'false', finishJSTest);

</script>

</body>